Re: [PATCH] Add Cobalt button interface driver support

2007-04-05 Thread Yoichi Yuasa
Hi Dmitry, On Wed, 4 Apr 2007 00:01:41 -0400 Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > Hi Yoichi, > > Could you please try the patch below? It moves platform device creation > code into cobalt arch code to belletr follow driver model. It works fine. Acked-by: Yoichi Yuasa <[EMAIL PROTECTED]

Re: [PATCH] Add Cobalt button interface driver support

2007-04-03 Thread Dmitry Torokhov
Hi Yoichi, Could you please try the patch below? It moves platform device creation code into cobalt arch code to belletr follow driver model. Thank you! -- Dmitry Input: cobalt buttons - separate device and driver registration Create platform device for cobalt buttons as part of arch setup. T

Re: [PATCH] Add Cobalt button interface driver support

2007-02-16 Thread Yoichi Yuasa
On Fri, 16 Feb 2007 10:15:11 -0500 "Dmitry Torokhov" <[EMAIL PROTECTED]> wrote: > On 2/16/07, Yoichi Yuasa <[EMAIL PROTECTED]> wrote: > > + > > +static int cobalt_buttons_open(struct inode *inode, struct file *file) > > +{ > > + buttons_timer.expires = jiffies + > > msecs_to_jiffies(BUTTONS

Re: [PATCH] Add Cobalt button interface driver support

2007-02-16 Thread Dmitry Torokhov
On 2/16/07, Yoichi Yuasa <[EMAIL PROTECTED]> wrote: + +static int cobalt_buttons_open(struct inode *inode, struct file *file) +{ + buttons_timer.expires = jiffies + msecs_to_jiffies(BUTTONS_POLL_INTERVAL); + add_timer(&buttons_timer); + + return nonseekable_open(inode, file); +

Re: [PATCH] Add Cobalt button interface driver support

2007-02-16 Thread Yoichi Yuasa
Hi, Thank you for your comments. On Thu, 15 Feb 2007 23:09:43 -0500 Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote: > > Hi, > > > > This patch adds support for the back panel buttons on Cobalt server. > > It's tested on the Cobalt Qube2. > >

[PATCH] Add Cobalt button interface driver support

2007-02-15 Thread Yoichi Yuasa
Hi, This patch adds support for the back panel buttons on Cobalt server. It's tested on the Cobalt Qube2. Yoichi Signed-off-by: Yoichi Yuasa <[EMAIL PROTECTED]> diff -pruN -X mips/Documentation/dontdiff mips-orig/drivers/input/misc/Kconfig mips/drivers/input/misc/Kconfig --- mips-orig/drivers/

Re: [PATCH] Add Cobalt button interface driver support

2007-02-15 Thread Dmitry Torokhov
On Thursday 15 February 2007 22:36, Yoichi Yuasa wrote: > Hi, > > This patch adds support for the back panel buttons on Cobalt server. > It's tested on the Cobalt Qube2. > Hi, Thank you for your patch. Couple of comments: > + > + button++; > + } > + > + mod_timer(&buttons_t