Re: [PATCH] Abort file_remove_privs() for non-reg. files

2019-03-08 Thread Alexander Lochmann
Hello Al, Meanwhile, have you had the opportunity to review our patch? Regards, Alex On 11.01.19 16:42, Alexander Lochmann wrote: > Hello Al, > > Have you had the opportunity to review our patch? > > Cheers, > Alex > > On 17.12.18 09:28, Jan Kara wrote: >> On Fri 14-12-18 11:55:52, Alexander

Re: [PATCH] Abort file_remove_privs() for non-reg. files

2019-01-11 Thread Alexander Lochmann
Hello Al, Have you had the opportunity to review our patch? Cheers, Alex On 17.12.18 09:28, Jan Kara wrote: > On Fri 14-12-18 11:55:52, Alexander Lochmann wrote: >> >> file_remove_privs() might be called for non-regular files, e.g. >> blkdev inode. There is no reason to do its job on things >> l

Re: [PATCH] Abort file_remove_privs() for non-reg. files

2018-12-17 Thread Jan Kara
On Fri 14-12-18 11:55:52, Alexander Lochmann wrote: > > file_remove_privs() might be called for non-regular files, e.g. > blkdev inode. There is no reason to do its job on things > like blkdev inodes, pipes, or cdevs. Hence, abort if > file does not refer to a regular inode. > The following stackt

[PATCH] Abort file_remove_privs() for non-reg. files

2018-12-14 Thread Alexander Lochmann
file_remove_privs() might be called for non-regular files, e.g. blkdev inode. There is no reason to do its job on things like blkdev inodes, pipes, or cdevs. Hence, abort if file does not refer to a regular inode. The following stacktrace shows how to get there: 13: entry_SYSENTER_32:460 12: do_fa