Re: [PATCH] ASoC: wm8962: Use force clear for WM8962_SYSCLK_ENA after reset

2020-05-13 Thread Mark Brown
On Wed, 13 May 2020 13:30:35 +0800, Shengjiu Wang wrote: > When CLOCKING2 is non-volatile register, we need force clear > the WM8962_SYSCLK_ENA bit after reset, for the value in cache > maybe 0 but in hardware it is 1. Otherwise there will issue > as below statement in driver. > > /* SYSCLK defaul

Re: [PATCH] ASoC: wm8962: Use force clear for WM8962_SYSCLK_ENA after reset

2020-05-13 Thread Charles Keepax
On Wed, May 13, 2020 at 01:30:35PM +0800, Shengjiu Wang wrote: > When CLOCKING2 is non-volatile register, we need force clear > the WM8962_SYSCLK_ENA bit after reset, for the value in cache > maybe 0 but in hardware it is 1. Otherwise there will issue > as below statement in driver. > > /* SYSCLK

[PATCH] ASoC: wm8962: Use force clear for WM8962_SYSCLK_ENA after reset

2020-05-12 Thread Shengjiu Wang
When CLOCKING2 is non-volatile register, we need force clear the WM8962_SYSCLK_ENA bit after reset, for the value in cache maybe 0 but in hardware it is 1. Otherwise there will issue as below statement in driver. /* SYSCLK defaults to on; make sure it is off so we can safely * write to registers