Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-06 Thread Andy Shevchenko
On Mon, Nov 05, 2018 at 10:19:02PM +0100, Arnd Bergmann wrote: > On 11/5/18, Andy Shevchenko wrote: > > On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart > > wrote: > >> >> config SND_SOC_HDAC_HDA_FORCE > >> >> tristate > > > >> >> depends on SND_SOC_ALL_CODECS != n > > > >

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart > wrote: >> >> >> >>> We have this ("strange") lines over the drivers: >> >>> >> >>> config BAR >> >>> depends on FOO || FOO=n >> >>> >> >>> which guarantees that FOO will be not module when BAR is built-in.

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Andy Shevchenko
On Mon, Nov 5, 2018 at 7:19 PM Pierre-Louis Bossart wrote: > > > >>> We have this ("strange") lines over the drivers: > >>> > >>> config BAR > >>> depends on FOO || FOO=n > >>> > >>> which guarantees that FOO will be not module when BAR is built-in. > >> That's what I normally use, but I could not

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Pierre-Louis Bossart
We have this ("strange") lines over the drivers: config BAR depends on FOO || FOO=n which guarantees that FOO will be not module when BAR is built-in. That's what I normally use, but I could not figure this one out. One problem is that SND_SOC_ALL_CODECS selects SND_SOC_HDAC_HDA, and SND_SOC

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Takashi Iwai
On Mon, 05 Nov 2018 16:07:50 +0100, Arnd Bergmann wrote: > > On 11/5/18, Andy Shevchenko wrote: > > On Sun, Nov 04, 2018 at 10:45:17AM -0600, Pierre-Louis Bossart wrote: > > > >> So yes indeed we have to add a select HDAC_HDA statement under the > >> SKYLAKE > >> config - i just don't know of any

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Arnd Bergmann
On 11/5/18, Andy Shevchenko wrote: > On Sun, Nov 04, 2018 at 10:45:17AM -0600, Pierre-Louis Bossart wrote: > >> So yes indeed we have to add a select HDAC_HDA statement under the >> SKYLAKE >> config - i just don't know of any other means to say "don't build >> HDAC_HDA >> as a module when SKYLAKE

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-05 Thread Andy Shevchenko
On Sun, Nov 04, 2018 at 10:45:17AM -0600, Pierre-Louis Bossart wrote: > So yes indeed we have to add a select HDAC_HDA statement under the SKYLAKE > config - i just don't know of any other means to say "don't build HDAC_HDA > as a module when SKYLAKE is buit-in" We have this ("strange") lines ove

Re: [alsa-devel] [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-04 Thread Pierre-Louis Bossart
On 11/2/18 5:03 PM, Arnd Bergmann wrote: On 11/2/18, Pierre-Louis Bossart wrote: On 11/2/18 6:24 AM, Arnd Bergmann wrote: The skylake sound support is written to work both with or without CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should link against that. However, this

Re: [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-02 Thread Arnd Bergmann
On 11/2/18, Pierre-Louis Bossart wrote: > > On 11/2/18 6:24 AM, Arnd Bergmann wrote: >> The skylake sound support is written to work both with or without >> CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should >> link against that. However, this fails with SND_SOC_ALL_CODECS=m o

Re: [PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-02 Thread Pierre-Louis Bossart
On 11/2/18 6:24 AM, Arnd Bergmann wrote: The skylake sound support is written to work both with or without CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should link against that. However, this fails with SND_SOC_ALL_CODECS=m or SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=m when th

[PATCH] ASoC: skl: always select SND_SOC_HDAC_HDA

2018-11-02 Thread Arnd Bergmann
The skylake sound support is written to work both with or without CONFIG_SND_SOC_HDAC_HDA, and uses an #ifdef to decide whether it should link against that. However, this fails with SND_SOC_ALL_CODECS=m or SND_SOC_INTEL_SKL_HDA_DSP_GENERIC_MACH=m when the Skylake support itself is built-in, with th