RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2014-01-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Tue, Dec 31, 2013 at 03:27:53AM +, li.xi...@freescale.com wrote: > > > Also, for most of the devices of the same DAI link, they use the same DAI > > formats, but I h

Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-31 Thread Mark Brown
On Tue, Dec 31, 2013 at 03:27:53AM +, li.xi...@freescale.com wrote: > Also, for most of the devices of the same DAI link, they use the same DAI > formats, but I have found some drivers like : "sound/soc/pxa/magician.c" > and "sound/soc/s6000/s6105-ipcam.c", etc, may have different DAI format >

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-30 Thread li.xi...@freescale.com
> Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Fri, Dec 27, 2013 at 11:14:38AM +0800, Xiubo Li wrote: > > Since there is only one common format via "simple-audio-card,format" > > for simple card driver(CPU &

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-30 Thread li.xi...@freescale.com
Hi Mark, > - > .. > > /* get CPU/CODEC common format via simple-audio-card,format */ > info->daifmt = snd_soc_of_parse_daifmt(node, "simple-audio-card,") & > (SND_SOC_DAIFMT_FORMAT_MASK | SND_SOC_DAIFMT_INV_MASK); > > .. > >

RE: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-30 Thread li.xi...@freescale.com
Hi Mark and all, Merry Christmas. > Subject: Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() > code > > On Fri, Dec 27, 2013 at 11:14:38AM +0800, Xiubo Li wrote: > > Since there is only one common format via "simple-audio-card,format" > >

Re: [PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-30 Thread Mark Brown
On Fri, Dec 27, 2013 at 11:14:38AM +0800, Xiubo Li wrote: > Since there is only one common format via "simple-audio-card,format" > for simple card driver(CPU & CODEC DAI), there is no need to do the > INV mask. I don't understand this change, how is the fact that the CPU and CODEC DAI share a comm

[PATCH] ASoC: simple-card: cleanup asoc_simple_card_parse_of() code

2013-12-26 Thread Xiubo Li
Since there is only one common format via "simple-audio-card,format" for simple card driver(CPU & CODEC DAI), there is no need to do the INV mask. Signed-off-by: Xiubo Li --- sound/soc/generic/simple-card.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/generic/sim