Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable data and associated code

2017-03-27 Thread Keyon Jie
On 2017年03月22日 22:36, Colin King wrote: From: Colin Ian King The variable 'data' is assigned null and never re-assigned. There is also a redundant check for data being non-null which is always false, so remove this and the variable data and dma_addr as they are not used once the dead code has

[PATCH] ASoC: intel: remove unused variable data and associated code

2017-03-22 Thread Colin King
From: Colin Ian King The variable 'data' is assigned null and never re-assigned. There is also a redundant check for data being non-null which is always false, so remove this and the variable data and dma_addr as they are not used once the dead code has been removed. Detected with CoverityScan,

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Sudip Mukherjee
On Wednesday 02 March 2016 06:50 PM, Mark Brown wrote: On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: Sudip Mukherjee wrote: My From: is Sudip Mukherjee and my Signed-off-by: is Sudip Mukherjee My From name and Signed-off name matches. But my emails donot match.

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Mark Brown
On Wed, Mar 02, 2016 at 01:53:23PM +, One Thousand Gnomes wrote: > > The other option is to just not use the work address if you don't want > > to use it (that's what I do). > That assumes your work email system can handle kernel traffic and doesn't > inflict things like Microsoft Outlook or

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread One Thousand Gnomes
> > The other option I suppose would be to put both addresses in the signed > > off by sequence, but that probably causes confusion > > The other option is to just not use the work address if you don't want > to use it (that's what I do). That assumes your work email system can handle kernel tr

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Mark Brown
On Wed, Mar 02, 2016 at 06:37:50PM +0530, Sudip Mukherjee wrote: > On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: > > The other option I suppose would be to put both addresses in the signed > > off by sequence, but that probably causes confusion > yes, maybe. I believe I sho

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Mark Brown
On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: > Sudip Mukherjee wrote: > > My From: is Sudip Mukherjee > > and my Signed-off-by: is Sudip Mukherjee > > My From name and Signed-off name matches. But my emails donot match. > Which is fine - unless you are submitting patch

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Sudip Mukherjee
On Wed, Mar 02, 2016 at 12:27:09PM +, One Thousand Gnomes wrote: > On Wed, 2 Mar 2016 11:56:28 +0530 > Sudip Mukherjee wrote: > > > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > > > > > Can i not kee

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread One Thousand Gnomes
On Wed, 2 Mar 2016 11:56:28 +0530 Sudip Mukherjee wrote: > On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > > > Can i not keep using my gmail as my From: ? > > > The advantage of using gmail as my From: is th

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-02 Thread Mark Brown
On Wed, Mar 02, 2016 at 11:56:28AM +0530, Sudip Mukherjee wrote: > > > And AFAIK, the From: name and the Signed-off-by: name should match else > > > the tools used by Greg and others to generate the stats will break. > > I don't understand - what I'm pointing out here is that they do not > > matc

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-01 Thread Sudip Mukherjee
On Wed, Mar 02, 2016 at 10:02:23AM +0900, Mark Brown wrote: > On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > > > Can i not keep using my gmail as my From: ? > > The advantage of using gmail as my From: is that the discussion and all > > threads related to my patches will be in

Re: [PATCH] ASoC: intel: remove unused variable

2016-03-01 Thread Mark Brown
On Tue, Mar 01, 2016 at 11:19:27AM +0530, Sudip Mukherjee wrote: > Can i not keep using my gmail as my From: ? > The advantage of using gmail as my From: is that the discussion and all > threads related to my patches will be in the same place even if my work > email is changed. That's fine (I'm d

Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Takashi Iwai
On Tue, 01 Mar 2016 06:49:27 +0100, Sudip Mukherjee wrote: > > On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote: > > On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > > > The variable cmd_id is only assigned some value and is never used. > > > > > > Signed-off-by: Sudip

Re: [PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Sudip Mukherjee
On Tue, Mar 01, 2016 at 11:59:12AM +0900, Mark Brown wrote: > On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > > The variable cmd_id is only assigned some value and is never used. > > > > Signed-off-by: Sudip Mukherjee > > Your signoff doesn't correspond to your e-mail address.

Re: [PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Mark Brown
On Mon, Feb 29, 2016 at 10:53:46PM +0530, Sudip Mukherjee wrote: > The variable cmd_id is only assigned some value and is never used. > > Signed-off-by: Sudip Mukherjee Your signoff doesn't correspond to your e-mail address. While I'm fairly sure that you are in fact the same person so it's OK

[PATCH] ASoC: intel: remove unused variable

2016-02-29 Thread Sudip Mukherjee
The variable cmd_id is only assigned some value and is never used. Signed-off-by: Sudip Mukherjee --- sound/soc/intel/atom/sst/sst_ipc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/intel/atom/sst/sst_ipc.c b/sound/soc/intel/atom/sst/sst_ipc.c index 3dc7358..8afa6fe 100644 ---