Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Nicolin Chen
On Wed, Sep 17, 2014 at 10:31:28AM +0800, Shawn Guo wrote: > On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote: > > It's not supported in the clock API or just not implemented in our > > code? Can we just register a clock without CLK_SET_RATE_PARENT to > > achieve the purpose? (We are ju

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shawn Guo
On Tue, Sep 16, 2014 at 07:24:40PM -0700, Nicolin Chen wrote: > It's not supported in the clock API or just not implemented in our > code? Can we just register a clock without CLK_SET_RATE_PARENT to > achieve the purpose? (We are just trying to fix those PRED and PODF > dividers when the driver cal

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Nicolin Chen
On Wed, Sep 17, 2014 at 09:32:52AM +0800, Shawn Guo wrote: > On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote: > > On Tue, Sep 16, 2014 at 07:46:34PM +0800, Shengjiu Wang wrote: > > > The spdif root clock may be used by other module or defined with > > > CLK_SET_RATE_GATE, so we can't c

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shawn Guo
On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote: > On Tue, Sep 16, 2014 at 07:46:34PM +0800, Shengjiu Wang wrote: > > The spdif root clock may be used by other module or defined with > > CLK_SET_RATE_GATE, so we can't change the clock rate in driver. > > In this patch remove the clk_se

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Mark Brown
On Tue, Sep 16, 2014 at 11:19:28AM -0700, Nicolin Chen wrote: > So I think, if it's a shared clock, we should not define it as a > rate-changeable one in the SoC level, as we might still have some > SoCs provide a dedicated clock to S/PDIF so as to get the maximum > range of clock support for user

Re: [PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Nicolin Chen
On Tue, Sep 16, 2014 at 07:46:34PM +0800, Shengjiu Wang wrote: > The spdif root clock may be used by other module or defined with > CLK_SET_RATE_GATE, so we can't change the clock rate in driver. > In this patch remove the clk_set_rate and clk_round_rate to protect the > clock. It's a quite conven

[PATCH] ASoC: fsl_spdif: don't change the root clock rate of spdif in driver

2014-09-16 Thread Shengjiu Wang
The spdif root clock may be used by other module or defined with CLK_SET_RATE_GATE, so we can't change the clock rate in driver. In this patch remove the clk_set_rate and clk_round_rate to protect the clock. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/fsl_spdif.c | 24 ++