Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-13 Thread Mark Brown
On Tue, Feb 13, 2018 at 09:22:24AM +, Cosmin Samoila wrote: > This is used to set the codec in Manual Setting Mode, meaning that > the default sampling speed is set based on DFS0 and DFS1 bits. In > Auto Setting Mode, the MCLK frequency is detected automatically and > DFS bits are ignored. Bu

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-13 Thread Cosmin Samoila
Hi Mark, > > > > +static int ak4458_hw_params(struct snd_pcm_substream *substream, > > + struct snd_pcm_hw_params *params, > > + struct snd_soc_dai *dai) > > +{ > > + struct snd_soc_codec *codec = dai->codec; > > + struct ak4458_priv *ak4458 = > > s

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-12 Thread Fabio Estevam
On Wed, Jan 31, 2018 at 11:20 AM, Cosmin-Gabriel Samoila wrote: > The AK4458 is a 32-bit 8ch Premium DAC that corresponds > to a 768kHz PCM input and an 11.2MHz DSD input at maximum. > It supports I2S, DSD and TDM modes with 24 or 32 bit MSB > or 16, 24, 32 LSB formats. Its datasheet is available

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-09 Thread Mark Brown
On Fri, Feb 09, 2018 at 10:22:16AM +, Cosmin Samoila wrote: > > > +static const char * const ak4458_dac_select_texts[] = { "OFF", > > > "ON" }; > > This looks like the users should be switch controls - what's the goal > > here? > I think this is to allow users to switch off sound for all chan

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-09 Thread Cosmin Samoila
Hi Mark, > > +static const struct soc_enum ak4458_dac_enum[] = { > > +/*0*/ SOC_ENUM_SINGLE(AK4458_01_CONTROL2, 1, > > + ARRAY_SIZE(ak4458_dem_select_texts), > > + ak4458_dem_select_texts), > > +/*1*/ SOC_ENUM_SINGLE(AK4458_0A_CONTROL6, 0, > The fact t

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-02-04 Thread Rob Herring
On Wed, Jan 31, 2018 at 03:20:09PM +0200, Cosmin-Gabriel Samoila wrote: > The AK4458 is a 32-bit 8ch Premium DAC that corresponds > to a 768kHz PCM input and an 11.2MHz DSD input at maximum. > It supports I2S, DSD and TDM modes with 24 or 32 bit MSB > or 16, 24, 32 LSB formats. Its datasheet is ava

Re: [PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-01-31 Thread Mark Brown
On Wed, Jan 31, 2018 at 03:20:09PM +0200, Cosmin-Gabriel Samoila wrote: This looks pretty good overall, I've got some issues below but nothing too major: > +static int ak4458_i2c_remove(struct i2c_client *i2c) > +{ > + ak4458_remove(&i2c->dev); > + pm_runtime_disable(&i2c->dev); It's wei

[PATCH] ASoC: codecs: Add support for AK4458 DAC driver

2018-01-31 Thread Cosmin-Gabriel Samoila
The AK4458 is a 32-bit 8ch Premium DAC that corresponds to a 768kHz PCM input and an 11.2MHz DSD input at maximum. It supports I2S, DSD and TDM modes with 24 or 32 bit MSB or 16, 24, 32 LSB formats. Its datasheet is available here: https://www.akm.com/akm/en/file/datasheet/AK4458VN.pdf Signed-off-