On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> This is a driver for the MAX9860 Mono Audio Voice Codec.
>
> https://datasheets.maximintegrated.com/en/ds/MAX9860.pdf
>
> This driver does not support sidetone since the DVST register field is
> backwards with the mute near the maximu
On Thu, May 12, 2016 at 09:54:18AM +0200, Peter Rosin wrote:
> On 2016-05-11 22:50, Mark Brown wrote:
> >> http://www.spinics.net/lists/alsa-devel/msg49675.html
> > If you don't CC maintainers the chances are your mails just won't get
> > seen...
> To me, it feels rude to single out people when
On Thu, May 12, 2016 at 10:24:11AM +0200, Peter Rosin wrote:
> On 2016-05-11 22:53, Mark Brown wrote:
> > The code needs to make it clear that this is an intentional fallthrough,
> > an explicit default case would help a lot.
> There was this comment above the two if statements leading into the s
On 2016-05-11 22:53, Mark Brown wrote:
> On Wed, May 11, 2016 at 10:28:12PM +0200, Peter Rosin wrote:
>> On 2016-05-11 17:29, Mark Brown wrote:
>>> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
>
+ if (master) {
+ switch (max9860->pclk_rate) {
>>>
[Dropping the DT crowd]
On 2016-05-11 22:50, Mark Brown wrote:
> On Wed, May 11, 2016 at 10:12:56PM +0200, Peter Rosin wrote:
>> On 2016-05-11 17:09, Mark Brown wrote:
>>> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
>
This driver does not support sidetone since the DVST regi
On 2016-05-11 17:09, Mark Brown wrote:
> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
>
>> This driver does not support sidetone since the DVST register field is
>> backwards with the mute near the maximum level instead of the minimum.
>
> Why would that be an issue? We support v
On Wed, May 11, 2016 at 10:28:12PM +0200, Peter Rosin wrote:
> On 2016-05-11 17:29, Mark Brown wrote:
> > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> >> + if (master) {
> >> + switch (max9860->pclk_rate) {
> >> + case 1200:
> >> +
On Wed, May 11, 2016 at 10:12:56PM +0200, Peter Rosin wrote:
> On 2016-05-11 17:09, Mark Brown wrote:
> > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> >> This driver does not support sidetone since the DVST register field is
> >> backwards with the mute near the maximum level ins
On 2016-05-11 17:29, Mark Brown wrote:
> On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
>
>> +if (master) {
>> +switch (max9860->pclk_rate) {
>> +case 1200:
>> +sysclk = MAX9860_FREQ_12MHZ;
>> +
On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> + if (master) {
> + switch (max9860->pclk_rate) {
> + case 1200:
> + sysclk = MAX9860_FREQ_12MHZ;
> + break;
> +
On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> This driver does not support sidetone since the DVST register field is
> backwards with the mute near the maximum level instead of the minimum.
Why would that be an issue? We support volume controls in either
direction.
signature.a
This is a driver for the MAX9860 Mono Audio Voice Codec.
https://datasheets.maximintegrated.com/en/ds/MAX9860.pdf
This driver does not support sidetone since the DVST register field is
backwards with the mute near the maximum level instead of the minimum.
Signed-off-by: Peter Rosin
---
.../dev
12 matches
Mail list logo
