Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-24 Thread jeffy
hi Mark, On 08/24/2017 06:18 PM, Mark Brown wrote: On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote: and i was trying to do something like: if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name))) continue; whic

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-24 Thread Mark Brown
On Thu, Aug 24, 2017 at 11:29:42AM +0800, jeffy wrote: > and i was trying to do something like: > if (dlc->dai_name && strcmp(dai->name, dlc->dai_name) > && (!dai->driver->name || strcmp(dai->driver->name, dlc->dai_name))) >continue; > which is add an accept case for: dai driver name is v

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread jeffy
Hi Mark, On 08/23/2017 07:06 PM, Mark Brown wrote: On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote: >i think the original check is allowing NULL dlc dai_name to be a match... >so we basically did: >reject when dlc dai_name is valid, but not match the dai name So it is, but this still lo

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-23 Thread Mark Brown
On Wed, Aug 23, 2017 at 07:42:55AM +0800, jeffy wrote: > i think the original check is allowing NULL dlc dai_name to be a match... > so we basically did: > reject when dlc dai_name is valid, but not match the dai name So it is, but this still looks like the wrong thing - it'll match on an empty D

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-22 Thread jeffy
hi Mark, On 08/23/2017 12:17 AM, Mark Brown wrote: On Tue, Aug 22, 2017 at 10:45:12PM +0800, Jeffy Chen wrote: - return dai; + if (!dlc->dai_name) + return dai; + if (!strcmp(dai->name, dlc->dai_nam

Re: [PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-22 Thread Mark Brown
On Tue, Aug 22, 2017 at 10:45:12PM +0800, Jeffy Chen wrote: > - return dai; > + if (!dlc->dai_name) > + return dai; > + if (!strcmp(dai->name, dlc->dai_name)) > + return dai; You wa

[PATCH] ASoC: Add a sanity check before using dai driver name

2017-08-22 Thread Jeffy Chen
The dai driver's name is allowed to be NULL. So add a sanity check for that. Signed-off-by: Jeffy Chen Reported-by: Donglin Peng --- sound/soc/soc-core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 77e7e2a11