Re: [alsa-devel] [PATCH] ASoC: Add PCM1681 codec driver.

2013-07-01 Thread Lars-Peter Clausen
On 06/26/2013 03:05 PM, Marek Belisko wrote: [...] > +static int pcm1681_deemph[] = { 44100, 48000, 32000 }; const > + > +static int pcm1681_set_deemph(struct snd_soc_codec *codec) > +{ > + struct pcm1681_private *priv = snd_soc_codec_get_drvdata(codec); > + int i = 0, val = -1, ret; > +

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-27 Thread Marek Belisko
Hi Mark, On 06/26/2013 04:30 PM, Mark Brown wrote: On Wed, Jun 26, 2013 at 03:05:28PM +0200, Marek Belisko wrote: +#define PCM1681_ATT_CONTROL(X) (X <= 6 ? X : X + 9) /* Attenuation level */ Write a function for this. This macro is used when creating controls for channels volume so this cann

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Mark Brown
On Wed, Jun 26, 2013 at 03:05:28PM +0200, Marek Belisko wrote: > +#define PCM1681_ATT_CONTROL(X) (X <= 6 ? X : X + 9) /* Attenuation > level */ Write a function for this. > +static bool pcm1681_writeable_reg(struct device *dev, unsigned register reg) > +{ > + return pcm1681_accessible

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Mark Brown
On Wed, Jun 26, 2013 at 03:16:56PM +0200, Daniel Mack wrote: > Hi Marek, > > On 26.06.2013 15:05, Marek Belisko wrote: > > PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add > > support only for I2C mode. Guys, please delete unneeded context from replies so it's possible t

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Daniel Mack
On 26.06.2013 15:46, Marek Belisko wrote: > Hi Daniel, > On 06/26/2013 03:16 PM, Daniel Mack wrote: >> Hi Marek, >> >> On 26.06.2013 15:05, Marek Belisko wrote: >>> PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add >>> support only for I2C mode. >>> >>> Signed-off-by: Marek

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Marek Belisko
Hi Daniel, On 06/26/2013 03:16 PM, Daniel Mack wrote: Hi Marek, On 26.06.2013 15:05, Marek Belisko wrote: PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add support only for I2C mode. Signed-off-by: Marek Belisko --- .../devicetree/bindings/sound/ti,pcm1681.txt

Re: [PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Daniel Mack
Hi Marek, On 26.06.2013 15:05, Marek Belisko wrote: > PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add > support only for I2C mode. > > Signed-off-by: Marek Belisko > --- > .../devicetree/bindings/sound/ti,pcm1681.txt | 15 + > sound/soc/codecs/Kconfig

[PATCH] ASoC: Add PCM1681 codec driver.

2013-06-26 Thread Marek Belisko
PCM1681 can be controlled via I2C, SPI or in bootstrap mode. This code add support only for I2C mode. Signed-off-by: Marek Belisko --- .../devicetree/bindings/sound/ti,pcm1681.txt | 15 + sound/soc/codecs/Kconfig |4 + sound/soc/codecs/Makefile