Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Russell King - ARM Linux
On Wed, Jan 18, 2017 at 03:38:52PM -0800, Laura Abbott wrote: > On 01/18/2017 02:36 PM, Russell King - ARM Linux wrote: > > I don't see why this needs to be in cacheflush.h - it doesn't seem to > > have anything to do with cache flushing, and placing it in here means > > that if you change the stat

Re: [kernel-hardening] Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Laura Abbott
On 01/18/2017 02:36 PM, Russell King - ARM Linux wrote: > On Wed, Jan 18, 2017 at 11:20:54AM -0800, Laura Abbott wrote: >> On 01/18/2017 05:53 AM, Jinbum Park wrote: >>> diff --git a/arch/arm/include/asm/cacheflush.h >>> b/arch/arm/include/asm/cacheflush.h >>> index bdd283b..741e2e8 100644 >>> ---

Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Kees Cook
On Wed, Jan 18, 2017 at 2:36 PM, Russell King - ARM Linux wrote: > On Wed, Jan 18, 2017 at 11:20:54AM -0800, Laura Abbott wrote: >> On 01/18/2017 05:53 AM, Jinbum Park wrote: >> > diff --git a/arch/arm/include/asm/cacheflush.h >> > b/arch/arm/include/asm/cacheflush.h >> > index bdd283b..741e2e8 1

Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Russell King - ARM Linux
On Wed, Jan 18, 2017 at 11:20:54AM -0800, Laura Abbott wrote: > On 01/18/2017 05:53 AM, Jinbum Park wrote: > > diff --git a/arch/arm/include/asm/cacheflush.h > > b/arch/arm/include/asm/cacheflush.h > > index bdd283b..741e2e8 100644 > > --- a/arch/arm/include/asm/cacheflush.h > > +++ b/arch/arm/inc

Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Kees Cook
On Wed, Jan 18, 2017 at 11:20 AM, Laura Abbott wrote: > On 01/18/2017 05:53 AM, Jinbum Park wrote: >> This patch adds testcases for the CONFIG_DEBUG_RODATA option. >> It's similar to x86's testcases. >> It tests read-only mapped data and page-size aligned rodata section. >> >> Signed-off-by: Jinbu

Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Laura Abbott
On 01/18/2017 05:53 AM, Jinbum Park wrote: > This patch adds testcases for the CONFIG_DEBUG_RODATA option. > It's similar to x86's testcases. > It tests read-only mapped data and page-size aligned rodata section. > > Signed-off-by: Jinbum Park > --- > arch/arm/Kconfig.debug| 5 +++ >

Re: [PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Mark Rutland
On Wed, Jan 18, 2017 at 10:53:10PM +0900, Jinbum Park wrote: > This patch adds testcases for the CONFIG_DEBUG_RODATA option. > It's similar to x86's testcases. > It tests read-only mapped data and page-size aligned rodata section. I note that LKDTM already has a similar test (though it just has a

[PATCH] ARM: mm: add testcases for RODATA

2017-01-18 Thread Jinbum Park
This patch adds testcases for the CONFIG_DEBUG_RODATA option. It's similar to x86's testcases. It tests read-only mapped data and page-size aligned rodata section. Signed-off-by: Jinbum Park --- arch/arm/Kconfig.debug| 5 +++ arch/arm/include/asm/cacheflush.h | 10 + arch/arm/mm