Re: [PATCH] ARM: kexec: validate CPU hotplug support

2013-08-01 Thread Russell King - ARM Linux
On Thu, Jul 11, 2013 at 04:48:51PM -0600, Stephen Warren wrote: > +int platform_can_cpu_hotplug(void) > +{ > + if (!IS_ENABLED(CONFIG_HOTPLUG_CPU) || !smp_ops.cpu_kill) > + return 0; This is an inappropriate usage of IS_ENABLED(). When hotplug CPU is disabled, there is no cpu_kill

Re: [PATCH] ARM: kexec: validate CPU hotplug support

2013-07-30 Thread Stephen Warren
On 07/19/2013 09:18 AM, Stephen Warren wrote: > On 07/11/2013 04:48 PM, Stephen Warren wrote: >> From: Stephen Warren >> >> Architectures should fully validate whether kexec is possible as part of >> machine_kexec_prepare(), so that user-space's kexec_load() operation can >> report any problems. P

Re: [PATCH] ARM: kexec: validate CPU hotplug support

2013-07-20 Thread Eric W. Biederman
Stephen Warren writes: > From: Stephen Warren > > Architectures should fully validate whether kexec is possible as part of > machine_kexec_prepare(), so that user-space's kexec_load() operation can > report any problems. Performing validation in machine_kexec() itself is > too late, since it is

Re: [PATCH] ARM: kexec: validate CPU hotplug support

2013-07-19 Thread Stephen Warren
On 07/11/2013 04:48 PM, Stephen Warren wrote: > From: Stephen Warren > > Architectures should fully validate whether kexec is possible as part of > machine_kexec_prepare(), so that user-space's kexec_load() operation can > report any problems. Performing validation in machine_kexec() itself is >

[PATCH] ARM: kexec: validate CPU hotplug support

2013-07-11 Thread Stephen Warren
From: Stephen Warren Architectures should fully validate whether kexec is possible as part of machine_kexec_prepare(), so that user-space's kexec_load() operation can report any problems. Performing validation in machine_kexec() itself is too late, since it is not allowed to return. Prior to thi