Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr

2014-03-21 Thread Liu hua
On 2014/3/18 18:48, Russell King - ARM Linux wrote: > On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote: >> When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will >> overflow if pfn >= 0x10 in copy_oldmem_page. >> >> So use __pfn_to_phys for converting. > > Yes. The sad thing is that i

Re: [PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr

2014-03-18 Thread Russell King - ARM Linux
On Tue, Mar 18, 2014 at 06:20:42PM +0800, Liu Hua wrote: > When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will > overflow if pfn >= 0x10 in copy_oldmem_page. > > So use __pfn_to_phys for converting. Yes. The sad thing is that if you grep the kernel for similar things, it's littered with

[PATCH] ARM: kdump: Avoid overflow when converting pfn to physaddr

2014-03-18 Thread Liu Hua
When we configure CONFIG_LPAE=y, pfn << PAGE_SHIFT will overflow if pfn >= 0x10 in copy_oldmem_page. So use __pfn_to_phys for converting. Signed-off-by: Liu Hua --- arch/arm/kernel/crash_dump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/kernel/crash_dump.c