[PATCH] ARM: imx: refactor mxc_iomux_mode()

2014-11-06 Thread Dmitry Voytik
Refactor mxc_iomux_mode(): - since it always returns 0 make it to return void - remove unnecessary ret variable - declare variables according to the kernel coding style Signed-off-by: Dmitry Voytik --- arch/arm/mach-imx/iomux-imx31.c | 8 arch/arm/mach-imx/iomux-mx3.h | 2 +- 2 fil

Re: [PATCH] ARM: imx: refactor mxc_iomux_mode()

2014-11-06 Thread Dmitry Voytik
Hi Peter, On Tue, Nov 04, 2014 at 12:21:55PM +, Peter Chen wrote: > > > -int mxc_iomux_mode(unsigned int pin_mode) > > > +void mxc_iomux_mode(unsigned int pin_mode) > > > { > > > - u32 field, l, mode, ret = 0; > > > + u32 field; > > > + u32 l; > > > + u32 mode; > > > void __iomem *reg; > >

RE: [PATCH] ARM: imx: refactor mxc_iomux_mode()

2014-11-04 Thread Peter Chen
> > On Tue, Oct 21, 2014 at 06:35:51PM +0400, Dmitry Voytik wrote: > > Refactor mxc_iomux_mode(): > > - since it always returns 0 make it to return void > > - remove unnecessary ret variable > > - declare variables according to the kernel coding style > > > > Signed-off-by: Dmitry Voytik > >

Re: [PATCH] ARM: imx: refactor mxc_iomux_mode()

2014-10-27 Thread Dmitry Voytik
Hi Shawn, Any comments on this? Thanks. On Tue, Oct 21, 2014 at 06:35:51PM +0400, Dmitry Voytik wrote: > Refactor mxc_iomux_mode(): > - since it always returns 0 make it to return void > - remove unnecessary ret variable > - declare variables according to the kernel coding style > > Signed-of

[PATCH] ARM: imx: refactor mxc_iomux_mode()

2014-10-21 Thread Dmitry Voytik
Refactor mxc_iomux_mode(): - since it always returns 0 make it to return void - remove unnecessary ret variable - declare variables according to the kernel coding style Signed-off-by: Dmitry Voytik --- arch/arm/mach-imx/iomux-imx31.c | 8 arch/arm/mach-imx/iomux-mx3.h | 2 +- 2 fil