Re: [PATCH] ARM: imx: clean up error handling

2014-05-15 Thread Emil Goode
Hello Dan, Thanks for the review and sorry for the late reply. On Thu, May 15, 2014 at 11:32:13PM +0300, Dan Carpenter wrote: > On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote: > > If we fail to allocate struct platform_device pdev we > > dereference it after the goto label err. > > >

Re: [PATCH] ARM: imx: clean up error handling

2014-05-15 Thread Dan Carpenter
On Thu, May 15, 2014 at 09:24:30PM +0200, Emil Goode wrote: > If we fail to allocate struct platform_device pdev we > dereference it after the goto label err. > > I have rearranged the error handling a bit to fix the issue > and also make it more clear. > > Signed-off-by: Emil Goode > --- > arc

[PATCH] ARM: imx: clean up error handling

2014-05-15 Thread Emil Goode
If we fail to allocate struct platform_device pdev we dereference it after the goto label err. I have rearranged the error handling a bit to fix the issue and also make it more clear. Signed-off-by: Emil Goode --- arch/arm/mach-imx/devices/platform-ipu-core.c | 22 +- 1 fi