Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 03:26:09PM -0700, Doug Anderson wrote: > Hi, > > Sigh. OK, hopefully correct now: > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/2 LGTM. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 3:02 PM Russell King - ARM Linux admin wrote: > > On Thu, Aug 06, 2020 at 11:28:09AM -0700, Doug Anderson wrote: > > Let's hope this one works: > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/1 > > Almost. It seems that you must have grabbed

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 11:28:09AM -0700, Doug Anderson wrote: > Let's hope this one works: > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/1 Almost. It seems that you must have grabbed a copy off the patch system, edited it and sent it back? The commit message appears t

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 8:45 AM Doug Anderson wrote: > > Hi, > > On Thu, Aug 6, 2020 at 8:41 AM Russell King - ARM Linux admin > wrote: > > > > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson > > > wrote: > >

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 04:41:44PM +0100, Russell King - ARM Linux admin wrote: > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > Yet if I go check mainline the patch is not there. This came to my > > attention since we had my patch picked to the Chrome OS 4.19 tree and > > sudd

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > Hi, > > On Wed, Nov 20, 2019 at 11:18 AM Will Deacon wrote: > > > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > > This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Handle inexact > > > watchpoint addresses")

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Russell King - ARM Linux admin
On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Nov 20, 2019 at 11:18 AM Will Deacon wrote: > > > > > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > > > This is commi

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 8:41 AM Russell King - ARM Linux admin wrote: > > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Wed, Nov 20, 2019 at 11:18 AM Will Deacon wrote: > > > >

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2019-10-22 Thread Matthias Kaehlcke
On Mon, Oct 21, 2019 at 04:49:48PM -0700, Doug Anderson wrote: > Hi, > > On Mon, Oct 21, 2019 at 11:47 AM Matthias Kaehlcke wrote: > > > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > > This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Handle inexact > > > watchpoint ad

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2019-10-21 Thread Doug Anderson
Hi, On Mon, Oct 21, 2019 at 11:47 AM Matthias Kaehlcke wrote: > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Handle inexact > > watchpoint addresses") but ported to arm32, which has the same > > problem. > > > > This p

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2019-10-21 Thread Matthias Kaehlcke
On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Handle inexact > watchpoint addresses") but ported to arm32, which has the same > problem. > > This problem was found by Android CTS tests, notably the > "watchpoint_imprecise" t

[PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2019-10-19 Thread Douglas Anderson
This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Handle inexact watchpoint addresses") but ported to arm32, which has the same problem. This problem was found by Android CTS tests, notably the "watchpoint_imprecise" test [1]. I tested locally against a copycat (simplified) version of the test