Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-19 Thread Javier Martinez Canillas
Hello, On 08/18/2015 09:01 AM, Javier Martinez Canillas wrote: > The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > symbol because the driver uses some communication helper functions in > drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > CROS_EC_PROTO inst

Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-18 Thread Javier Martinez Canillas
Hello Krzysztof, On 08/18/2015 10:09 AM, Krzysztof Kozlowski wrote: > On 18.08.2015 17:05, Javier Martinez Canillas wrote: >> Hello Krzysztof, >> >> On 08/18/2015 09:57 AM, Krzysztof Kozlowski wrote: >>> On 18.08.2015 16:01, Javier Martinez Canillas wrote: The ChromeOS mfd driver (MFD_CROS_EC

Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-18 Thread Krzysztof Kozlowski
On 18.08.2015 17:05, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 08/18/2015 09:57 AM, Krzysztof Kozlowski wrote: >> On 18.08.2015 16:01, Javier Martinez Canillas wrote: >>> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config >>> symbol because the driver uses some c

Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-18 Thread Javier Martinez Canillas
Hello Krzysztof, On 08/18/2015 09:57 AM, Krzysztof Kozlowski wrote: > On 18.08.2015 16:01, Javier Martinez Canillas wrote: >> The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config >> symbol because the driver uses some communication helper functions in >> drivers/platform/chrome/cr

Re: [PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-18 Thread Krzysztof Kozlowski
On 18.08.2015 16:01, Javier Martinez Canillas wrote: > The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config > symbol because the driver uses some communication helper functions in > drivers/platform/chrome/cros_ec_proto.c but other drivers depends on > CROS_EC_PROTO instead. Mixing

[PATCH] ARM: exynos_defconfig: Enable CROS_EC_PROTO for ChromeOS EC mfd driver

2015-08-18 Thread Javier Martinez Canillas
The ChromeOS mfd driver (MFD_CROS_EC) select the CROS_EC_PROTO config symbol because the driver uses some communication helper functions in drivers/platform/chrome/cros_ec_proto.c but other drivers depends on CROS_EC_PROTO instead. Mixing select and depends can lead to circular Kconfig dependencies