On Thu, 25 May 2017 11:03:20 +0300
Nikita Yushchenko wrote:
> >> "Crap origin" here is that in vast majority of cases, polarity is
> >> per-chip, not per-chip-use, knowledge. And proper location for per-chip
> >> knowledge is chip's driver. Moving this knowledge to per-chip-use
> >> location in
On Thu, May 25, 2017 at 11:06:47AM +0300, Nikita Yushchenko wrote:
> >> +&edma1 {
> >> + status = "okay";
> >> +};
> >> +
> >> +&dspi2 {
> >
> > Please keep these labelled nodes sort alphabetically.
>
> Ok
>
> >> + bus-num = <1>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&pinctrl
>> +&edma1 {
>> +status = "okay";
>> +};
>> +
>> +&dspi2 {
>
> Please keep these labelled nodes sort alphabetically.
Ok
>> +bus-num = <1>;
>> +pinctrl-names = "default";
>> +pinctrl-0 = <&pinctrl_dspi2>;
>> +status = "okay";
>
> We usually have 'status' line at the bottom of
>> "Crap origin" here is that in vast majority of cases, polarity is
>> per-chip, not per-chip-use, knowledge. And proper location for per-chip
>> knowledge is chip's driver. Moving this knowledge to per-chip-use
>> location in device trees only provides a source for errors, with little
>> gain.
>
On Tue, May 23, 2017 at 09:02:27AM +0300, Nikita Yushchenko wrote:
> >> However, hi8435 driver historically was coded using inverted values
> >> passed to gpiolib calls. And there are setups in the wild with device
> >> trees containing GPIO_ACTIVE_HIGH that I'd prefer not breaking.
> >>
> >> To s
On Mon, May 22, 2017 at 04:10:10PM +0300, Nikita Yushchenko wrote:
> ZII dev board rev B has a Holt Hi8435 connected to dspi2.
> Add it to device tree.
>
> ZII dev board rev C does not have that, so use rev-b dts file,
> not common dtsi file.
>
> Signed-off-by: Nikita Yushchenko
> ---
> arch/ar
>> However, hi8435 driver historically was coded using inverted values
>> passed to gpiolib calls. And there are setups in the wild with device
>> trees containing GPIO_ACTIVE_HIGH that I'd prefer not breaking.
>>
>> To solve, I submitted a patch on hi8435 driver that changes to _raw()
>> gpio cal
On Mon, May 22, 2017 at 07:29:14PM +0300, Nikita Yushchenko wrote:
> >> + hi8435@1 {
> >> + compatible = "holt,hi8435";
> >> + reg = <1>;
> >> + spi-max-frequency = <2000>;
> >> + gpios = <&gpio5 3 0>;
> >
> > Nit: GPIO_ACTIVE_HIGH instead of 0?
>
> Gray a
>> +hi8435@1 {
>> +compatible = "holt,hi8435";
>> +reg = <1>;
>> +spi-max-frequency = <2000>;
>> +gpios = <&gpio5 3 0>;
>
> Nit: GPIO_ACTIVE_HIGH instead of 0?
Gray area here.
Chip's reset input is active LOW.
However, hi8435 driver histor
On 2017-05-22 06:10, Nikita Yushchenko wrote:
> ZII dev board rev B has a Holt Hi8435 connected to dspi2.
> Add it to device tree.
>
> ZII dev board rev C does not have that, so use rev-b dts file,
> not common dtsi file.
>
> Signed-off-by: Nikita Yushchenko
> ---
> arch/arm/boot/dts/vf610-zii-
ZII dev board rev B has a Holt Hi8435 connected to dspi2.
Add it to device tree.
ZII dev board rev C does not have that, so use rev-b dts file,
not common dtsi file.
Signed-off-by: Nikita Yushchenko
---
arch/arm/boot/dts/vf610-zii-dev-rev-b.dts | 19 +++
1 file changed, 19 inser
11 matches
Mail list logo
