Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-05 Thread Nicolas Pitre
On Wed, 5 Jun 2013, Stephen Boyd wrote: > On 06/04, Nicolas Pitre wrote: > > > > The LC0 area should be considered read-only as it may be located in > > flash. > > > > Here's what I came with instead: > > > > From: Nicolas Pitre > > Date: Tue, 4 Jun 2013 17:01:30 -0400 > > Subject: [PATCH] AR

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-05 Thread Stephen Boyd
On 06/04, Nicolas Pitre wrote: > > The LC0 area should be considered read-only as it may be located in > flash. > > Here's what I came with instead: > > From: Nicolas Pitre > Date: Tue, 4 Jun 2013 17:01:30 -0400 > Subject: [PATCH] ARM: zImage: don't overwrite ourself with a page table > > Whe

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-04 Thread Nicolas Pitre
On Tue, 4 Jun 2013, Stephen Boyd wrote: > On 06/04, Nicolas Pitre wrote: > > diff --git a/arch/arm/boot/compressed/head.S > > b/arch/arm/boot/compressed/head.S > > index 9a94f344df..773bc35f92 100644 > > --- a/arch/arm/boot/compressed/head.S > > +++ b/arch/arm/boot/compressed/head.S > > @@ -178,1

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-04 Thread Stephen Boyd
On 06/04, Nicolas Pitre wrote: > On Tue, 4 Jun 2013, Stephen Boyd wrote: > > > On 06/04, Nicolas Pitre wrote: > > > > > > I've looked at the code and I think that #1 in your initial options is > > > probably best here. I agree with Russell about #2 being way too complex > > > for only this cas

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-04 Thread Nicolas Pitre
On Tue, 4 Jun 2013, Stephen Boyd wrote: > On 06/04, Nicolas Pitre wrote: > > On Mon, 3 Jun 2013, Stephen Boyd wrote: > > > > > On 06/03/13 15:45, Russell King - ARM Linux wrote: > > > > On Mon, Jun 03, 2013 at 03:37:39PM -0700, Stephen Boyd wrote: > > > >> In my case I'm booting a kernel with tex

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-04 Thread Stephen Boyd
On 06/04, Nicolas Pitre wrote: > On Mon, 3 Jun 2013, Stephen Boyd wrote: > > > On 06/03/13 15:45, Russell King - ARM Linux wrote: > > > On Mon, Jun 03, 2013 at 03:37:39PM -0700, Stephen Boyd wrote: > > >> In my case I'm booting a kernel with textoffset = 0x208000 but RAM > > >> starts at 0x0. Does

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Nicolas Pitre
On Mon, 3 Jun 2013, Stephen Boyd wrote: > On 06/03/13 15:45, Russell King - ARM Linux wrote: > > On Mon, Jun 03, 2013 at 03:37:39PM -0700, Stephen Boyd wrote: > >> In my case I'm booting a kernel with textoffset = 0x208000 but RAM > >> starts at 0x0. Does "minimum of RAM start" mean 0x0 or 0x2

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Stephen Boyd
On 06/03/13 15:45, Russell King - ARM Linux wrote: > On Mon, Jun 03, 2013 at 03:37:39PM -0700, Stephen Boyd wrote: >> In my case I'm booting a kernel with textoffset = 0x208000 but RAM >> starts at 0x0. Does "minimum of RAM start" mean 0x0 or 0x20? > The basic requirement for zImage's is no les

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Russell King - ARM Linux
On Mon, Jun 03, 2013 at 03:37:39PM -0700, Stephen Boyd wrote: > On 06/03/13 15:23, Russell King - ARM Linux wrote: > > On Mon, Jun 03, 2013 at 02:13:39PM -0700, Stephen Boyd wrote: > >> We > >> can't get any information about why the decompression failed if > >> we have debug_ll enabled. I had to p

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Russell King - ARM Linux
On Mon, Jun 03, 2013 at 05:33:45PM -0400, Nicolas Pitre wrote: > > On 05/24/13 15:05, Stephen Boyd wrote: > > > I see a few solutions. > > > > > > 1) Relocate with caches off and then turn on caches after we're > > > running in a location where we won't overwrite ourselves. > > Due to the cos

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Stephen Boyd
On 06/03/13 15:23, Russell King - ARM Linux wrote: > On Mon, Jun 03, 2013 at 02:13:39PM -0700, Stephen Boyd wrote: >> We >> can't get any information about why the decompression failed if >> we have debug_ll enabled. I had to patch the error() routine to >> not while loop forever to get that print

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Russell King - ARM Linux
On Mon, Jun 03, 2013 at 02:13:39PM -0700, Stephen Boyd wrote: > Resending due to rmk's vacation. > > On 05/24/13 15:05, Stephen Boyd wrote: > > I've noticed another problem now that our caches are used. On MSM > > we have TEXT_OFFSET set to at least 0x208000 if we've built-in > > support for MSM8x

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Nicolas Pitre
> On 05/24/13 15:05, Stephen Boyd wrote: > > I see a few solutions. > > > > 1) Relocate with caches off and then turn on caches after we're > > running in a location where we won't overwrite ourselves. Due to the cost of doing memory copy with the cache off, thisoption should be conditionall

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-06-03 Thread Stephen Boyd
Resending due to rmk's vacation. On 05/24/13 15:05, Stephen Boyd wrote: > I've noticed another problem now that our caches are used. On MSM > we have TEXT_OFFSET set to at least 0x208000 if we've built-in > support for MSM8x60/8960. If I boot a kernel with the MSM code > built-in that requires the

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-24 Thread Stephen Boyd
On 05/24, Russell King - ARM Linux wrote: > On Thu, May 23, 2013 at 10:54:26AM -0700, Stephen Boyd wrote: > > On 05/15/13 12:38, Stephen Boyd wrote: > > > On 05/08/13 14:47, Stephen Boyd wrote: > > >> From: Brian Swetland > > >> > > >> Currently v7 CPUs with an MIDR that has no bits set in the ran

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 10:54:26AM -0700, Stephen Boyd wrote: > On 05/15/13 12:38, Stephen Boyd wrote: > > On 05/08/13 14:47, Stephen Boyd wrote: > >> From: Brian Swetland > >> > >> Currently v7 CPUs with an MIDR that has no bits set in the range > >> [16:12] will be detected as old ARM CPUs with

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-23 Thread Stephen Boyd
On 05/15/13 12:38, Stephen Boyd wrote: > On 05/08/13 14:47, Stephen Boyd wrote: >> From: Brian Swetland >> >> Currently v7 CPUs with an MIDR that has no bits set in the range >> [16:12] will be detected as old ARM CPUs with no caches and so >> the cache will never be turned on during decompression

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-15 Thread Stephen Boyd
On 05/08/13 14:47, Stephen Boyd wrote: > From: Brian Swetland > > Currently v7 CPUs with an MIDR that has no bits set in the range > [16:12] will be detected as old ARM CPUs with no caches and so > the cache will never be turned on during decompression. ARM's > Cortex chips have an 0xC in the rang

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-08 Thread Stephen Boyd
On 05/08/13 14:47, Stephen Boyd wrote: > From: Brian Swetland > > Currently v7 CPUs with an MIDR that has no bits set in the range > [16:12] will be detected as old ARM CPUs with no caches and so I mean [15:12], sorry. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted

[PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-08 Thread Stephen Boyd
From: Brian Swetland Currently v7 CPUs with an MIDR that has no bits set in the range [16:12] will be detected as old ARM CPUs with no caches and so the cache will never be turned on during decompression. ARM's Cortex chips have an 0xC in the range [16:12] so they never match this entry, but Qual