Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2015-01-21 Thread Alexandre Courbot
On Tue, Jan 13, 2015 at 8:20 PM, Marek Szyprowski wrote: > Hello, > > On 2015-01-13 09:45, Alexandre Courbot wrote: >> >> Ping? This patch still seems to be needed as of today... > > > Arnd, could you take this patch together with your other pending > dma-mapping.h changes? Arnd, gentle ping on t

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2015-01-13 Thread Marek Szyprowski
Hello, On 2015-01-13 09:45, Alexandre Courbot wrote: Ping? This patch still seems to be needed as of today... Arnd, could you take this patch together with your other pending dma-mapping.h changes? On Thu, Dec 11, 2014 at 8:12 PM, Marek Szyprowski wrote: On 2014-12-08 09:39, Alexandre Co

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2015-01-13 Thread Alexandre Courbot
Ping? This patch still seems to be needed as of today... On Thu, Dec 11, 2014 at 8:12 PM, Marek Szyprowski wrote: > > On 2014-12-08 09:39, Alexandre Courbot wrote: >> >> There doesn't seem to be any valid reason to allocate the pages array >> with the same flags as the buffer itself. Doing so can

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2014-12-11 Thread Marek Szyprowski
On 2014-12-08 09:39, Alexandre Courbot wrote: There doesn't seem to be any valid reason to allocate the pages array with the same flags as the buffer itself. Doing so can eventually lead to the following safeguard in mm/slab.c to be hit: BUG_ON(flags & GFP_SLAB_BUG_MASK); This happens when buf

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2014-12-09 Thread Arnd Bergmann
On Tuesday 09 December 2014 11:57:22 Alexandre Courbot wrote: > On Mon, Dec 8, 2014 at 7:24 PM, Arnd Bergmann wrote: > > On Monday 08 December 2014 17:39:27 Alexandre Courbot wrote: > >> There doesn't seem to be any valid reason to allocate the pages array > >> with the same flags as the buffer it

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2014-12-08 Thread Alexandre Courbot
On Mon, Dec 8, 2014 at 7:24 PM, Arnd Bergmann wrote: > On Monday 08 December 2014 17:39:27 Alexandre Courbot wrote: >> There doesn't seem to be any valid reason to allocate the pages array >> with the same flags as the buffer itself. Doing so can eventually lead >> to the following safeguard in mm

Re: [PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2014-12-08 Thread Arnd Bergmann
On Monday 08 December 2014 17:39:27 Alexandre Courbot wrote: > There doesn't seem to be any valid reason to allocate the pages array > with the same flags as the buffer itself. Doing so can eventually lead > to the following safeguard in mm/slab.c to be hit: > > BUG_ON(flags & GFP_SLAB_BUG_MASK);

[PATCH] ARM: DMA: Fix kzalloc flags in __iommu_alloc_buffer()

2014-12-08 Thread Alexandre Courbot
There doesn't seem to be any valid reason to allocate the pages array with the same flags as the buffer itself. Doing so can eventually lead to the following safeguard in mm/slab.c to be hit: BUG_ON(flags & GFP_SLAB_BUG_MASK); This happens when buffers are allocated with __GFP_DMA32 or __GFP_HIGH