Re: [PATCH] ALSA: usb-audio: Fix unintentional sign extension issue

2021-03-18 Thread Takashi Iwai
On Thu, 18 Mar 2021 14:20:08 +0100, Colin King wrote: > > From: Colin Ian King > > The shifting of the u8 integer device by 24 bits to the left will > be promoted to a 32 bit signed int and then sign-extended to a > 64 bit unsigned long. In the event that the top bit of device is > set then all

[PATCH] ALSA: usb-audio: Fix unintentional sign extension issue

2021-03-18 Thread Colin King
From: Colin Ian King The shifting of the u8 integer device by 24 bits to the left will be promoted to a 32 bit signed int and then sign-extended to a 64 bit unsigned long. In the event that the top bit of device is set then all then all the upper 32 bits of the unsigned long will end up as also b