Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-30 Thread Ioan-Adrian Ratiu
On Fri, 30 Dec 2016, Takashi Iwai wrote: > On Wed, 21 Dec 2016 11:38:54 +0100, > Ioan-Adrian Ratiu wrote: >> >> >> > Please take the time to fully analyze my patch and let's have a >> >> > discussion based on it, not reject it outright and replace it with >> >> > a quick and dirty delay hack. >>

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-30 Thread Takashi Iwai
On Wed, 21 Dec 2016 11:38:54 +0100, Ioan-Adrian Ratiu wrote: > > >> > Please take the time to fully analyze my patch and let's have a > >> > discussion based on it, not reject it outright and replace it with > >> > a quick and dirty delay hack. > >> > >> OK. I'll deliberately check it again so th

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-21 Thread Ioan-Adrian Ratiu
Hi On Wed, 21 Dec 2016, Takashi Iwai wrote: > On Tue, 20 Dec 2016 14:04:56 +0100, > Takashi Sakamoto wrote: >> >> Hi, >> >> On Dec 20 2016 20:47, Ioan-Adrian Ratiu wrote: >> > On Tue, 20 Dec 2016, Takashi Sakamoto wrote: >> >> --- >> >> >> >> Hi, >> >> >> >>> Commit 16200948d835 ("ALSA: usb-au

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-21 Thread Takashi Iwai
On Tue, 20 Dec 2016 14:04:56 +0100, Takashi Sakamoto wrote: > > Hi, > > On Dec 20 2016 20:47, Ioan-Adrian Ratiu wrote: > > On Tue, 20 Dec 2016, Takashi Sakamoto wrote: > >> --- > >> > >> Hi, > >> > >>> Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream") > >>> fixes a race-co

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-20 Thread Takashi Sakamoto
Hi, On Dec 20 2016 20:47, Ioan-Adrian Ratiu wrote: On Tue, 20 Dec 2016, Takashi Sakamoto wrote: --- Hi, Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream") fixes a race-codition but it also introduces another really nasty data race regression which makes my usb sound ca

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-20 Thread Ioan-Adrian Ratiu
On Tue, 20 Dec 2016, Takashi Sakamoto wrote: > --- > > Hi, > >> Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream") >> fixes a race-codition but it also introduces another really nasty data race >> regression which makes my usb sound card [1] completely useless, throwing >> th

Re: [PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-19 Thread Takashi Sakamoto
--- Hi, > Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream") > fixes a race-codition but it also introduces another really nasty data race > regression which makes my usb sound card [1] completely useless, throwing > the kernel into a panic if anything from userspace tries t

[PATCH] ALSA: snd-usb: fix IRQ triggered NULL pointer dereference

2016-12-17 Thread Ioan-Adrian Ratiu
Commit 16200948d835 ("ALSA: usb-audio: Fix race at stopping the stream") fixes a race-codition but it also introduces another really nasty data race regression which makes my usb sound card [1] completely useless, throwing the kernel into a panic if anything from userspace tries to start playback.