Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A

2020-08-26 Thread Takashi Iwai
On Wed, 26 Aug 2020 10:40:14 +0200, Adrien Crivelli wrote: > > The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298 > codec as other Samsung laptops which have the no headphone sound bug. I > confirmed on my own hardware that this fixes the bug. > > This also correct the model name

[PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion NT950XCJ-X716A

2020-08-26 Thread Adrien Crivelli
The Galaxy Book Ion NT950XCJ-X716A (15 inches) uses the same ALC298 codec as other Samsung laptops which have the no headphone sound bug. I confirmed on my own hardware that this fixes the bug. This also correct the model name for the 13 inches version. It was incorrectly referenced as NT950XCJ-X7

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

2020-08-25 Thread Takashi Iwai
On Tue, 25 Aug 2020 16:36:13 +0200, Adrien Crivelli wrote: > > [1 ] > > I believe the code is correct (even though the diff is confusing), but I can > edit the commit message to also mention the model name. > > Should I submit the patch here as a reply ? or should I create a brand new > submiss

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

2020-08-25 Thread Takashi Iwai
On Mon, 24 Aug 2020 14:31:17 +0200, Alex Dewar wrote: > > My mistake -- I didn't read your changelog properly. Sorry! Would you resubmit the corrected fix patch? Also, better to indicate the device id number in the patch description. It's confusing which entry you've corrected intentionally for

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

2020-08-24 Thread Alex Dewar
My mistake -- I didn't read your changelog properly. Sorry! On 24/08/2020 13:30, Alex Dewar wrote: There's a mistake in this. The ID numbers are the wrong way round. Alex

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

2020-08-24 Thread Alex Dewar
There's a mistake in this. The ID numbers are the wrong way round. Alex

[PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion 15 inches

2020-08-24 Thread Adrien Crivelli
The Galaxy Book Ion 15 inches uses the same ALC298 codec as other Samsung laptops which have the no headphone sound bug. I confirmed on my own hardware that this fixes the bug. Commit e17f02d05 mixed up 13 inches and 15 inches models. This clarifies the situation with the correct model names. Bug

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion

2020-08-18 Thread Takashi Iwai
On Tue, 18 Aug 2020 18:54:44 +0200, Mike Pozulp wrote: > > The Galaxy Book Ion uses the same ALC298 codec as other Samsung laptops > which have the no headphone sound bug, like my Samsung Notebook. The > Galaxy Book owner confirmed that this patch fixes the bug. > > BugLink: https://bugzilla.kern

[PATCH] ALSA: hda/realtek: Add quirk for Samsung Galaxy Book Ion

2020-08-18 Thread Mike Pozulp
The Galaxy Book Ion uses the same ALC298 codec as other Samsung laptops which have the no headphone sound bug, like my Samsung Notebook. The Galaxy Book owner confirmed that this patch fixes the bug. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=207423 Signed-off-by: Mike Pozulp --- sound