Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-28 Thread Takashi Sakamoto
On Nov 28 2017 04:51, Takashi Iwai wrote: On Mon, 27 Nov 2017 18:34:17 +0100, Takashi Sakamoto wrote: Hi, On Nov 27 2017 21:58, Colin King wrote: From: Colin Ian King Don't populate array 'names' on the stack but instead make them static. Makes the object code smaller by 50 bytes: Before:

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread Takashi Iwai
On Mon, 27 Nov 2017 18:34:17 +0100, Takashi Sakamoto wrote: > > Hi, > > On Nov 27 2017 21:58, Colin King wrote: > > From: Colin Ian King > > > > Don't populate array 'names' on the stack but instead make them static. > > Makes the object code smaller by 50 bytes: > > > > Before: > > text

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread Takashi Iwai
On Mon, 27 Nov 2017 13:58:51 +0100, Colin King wrote: > > From: Colin Ian King > > Don't populate array 'names' on the stack but instead make them static. > Makes the object code smaller by 50 bytes: > > Before: >text data bss dec hex filename > 21237 9192

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread Takashi Sakamoto
Hi, On Nov 27 2017 21:58, Colin King wrote: From: Colin Ian King Don't populate array 'names' on the stack but instead make them static. Makes the object code smaller by 50 bytes: Before: text data bss dec hex filename 21237 91921120 315497b3d

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread walter harms
Am 27.11.2017 16:40, schrieb Joe Perches: > On Mon, 2017-11-27 at 15:55 +0100, walter harms wrote: >> Am 27.11.2017 13:58, schrieb Colin King: >>> From: Colin Ian King >>> Don't populate array 'names' on the stack but instead make them static. >>> Makes the object code smaller by 50 bytes: > []

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread Joe Perches
On Mon, 2017-11-27 at 15:55 +0100, walter harms wrote: > Am 27.11.2017 13:58, schrieb Colin King: > > From: Colin Ian King > > Don't populate array 'names' on the stack but instead make them static. > > Makes the object code smaller by 50 bytes: [] > > diff --git a/sound/drivers/dummy.c b/sound/dr

Re: [PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread walter harms
Am 27.11.2017 13:58, schrieb Colin King: > From: Colin Ian King > > Don't populate array 'names' on the stack but instead make them static. > Makes the object code smaller by 50 bytes: > > Before: >text data bss dec hex filename > 21237 91921120 31549

[PATCH] ALSA: drivers: make array 'names' const, reduces object code size

2017-11-27 Thread Colin King
From: Colin Ian King Don't populate array 'names' on the stack but instead make them static. Makes the object code smaller by 50 bytes: Before: textdata bss dec hex filename 2123791921120 315497b3d linux/sound/drivers/dummy.o After: textdata bss