Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-29 Thread Takashi Iwai
At Fri, 29 May 2015 17:49:06 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 17:01, Takashi Iwai wrote: > >>> Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into > >>> soundbus/sysfs.c, and make it this global instead of > >>> soundbus_dev_attrs[]. > >> Ok, I need to find a nice

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-29 Thread Quentin Lambert
On 28/05/2015 17:01, Takashi Iwai wrote: Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS declares the structure as static. If it resul

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Takashi Iwai
At Thu, 28 May 2015 16:43:12 +0200, Quentin Lambert wrote: > > On 28/05/2015 16:09, Takashi Iwai wrote: > > At Thu, 28 May 2015 15:59:50 +0200, > > Quentin Lambert wrote: > >> > >> > >> On 28/05/2015 15:52, Takashi Iwai wrote: > >>> At Thu, 28 May 2015 14:48:27 +0200, > >>> Quentin Lambert wrote:

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 16:09, Takashi Iwai wrote: At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts t

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Takashi Iwai
At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: > > > > On 28/05/2015 15:52, Takashi Iwai wrote: > > At Thu, 28 May 2015 14:48:27 +0200, > > Quentin Lambert wrote: > >> You should use dev_groups instead of the dev_attrs field of struct > >> bus_type. This converts the MDIO bus code to

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-of

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-of

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Takashi Iwai
At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: > > You should use dev_groups instead of the dev_attrs field of struct > bus_type. This converts the MDIO bus code to use the correct field. > > These modifications were made using Coccinelle. > > Signed-off-by: Quentin Lambert What's

[PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- sound/aoa/soundbus/core.c |3 ++- sound/aoa/soundbus/soundbus.h |