Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Xiaotian Feng
On Tue, Jul 23, 2013 at 5:28 AM, Tejun Heo wrote: > Hello, Xiaotian. > > Thanks for the fix. A couple comments below. > > On Wed, Jul 17, 2013 at 02:10:39PM +0800, Xiaotian Feng wrote: >> for (i = 0; i < host->n_ports; i++) { >> struct ahci_port_priv *pp = host->ports[i]->priv

Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-22 Thread Tejun Heo
Hello, Xiaotian. Thanks for the fix. A couple comments below. On Wed, Jul 17, 2013 at 02:10:39PM +0800, Xiaotian Feng wrote: > for (i = 0; i < host->n_ports; i++) { > struct ahci_port_priv *pp = host->ports[i]->private_data; > + const char *desc; > > +

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-16 Thread Xiaotian Feng
commit b29900e6 (AHCI: Make distinct names for ports in /proc/interrupts) introuded a regression, which resulted Null pointer dereference for achi host with dummy ports. For ahci ports, when the port is dummy port, its private_data will be NULL, as ata_dummy_port_ops doesn't support ->port_start.

Re: [PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-16 Thread Sergei Shtylyov
Hello. On 16-07-2013 9:18, Xiaotian Feng wrote: commit b29900e6 introuded a regression, which resulted Null pointer Please also specify that commit's summary in parens. dereference for achi host with dummy ports. For ahci ports, when the port is dummy port, its private_data will be NULL,

[PATCH] AHCI: fix Null pointer dereference in achi_host_active()

2013-07-15 Thread Xiaotian Feng
commit b29900e6 introuded a regression, which resulted Null pointer dereference for achi host with dummy ports. For ahci ports, when the port is dummy port, its private_data will be NULL, as ata_dummy_port_ops doesn't support ->port_start. Reported-and-tested-by: Alex Williamson Signed-off-by: Xi