Re: [PATCH] ADP1653 board code for Nokia RX-51

Hi! > +static int __init rx51_camera_hw_init(void) > +{ > + int rval; > + > + rval = rx51_adp1653_init(); > + if (rval) > + return rval; > + > + return 0; > +} "return rx51_adp1653_init()". Or better yet, rename rx51_adp1653_init to rx51_camera_hw_init. Thanks for al

Re: [PATCH] ADP1653 board code for Nokia RX-51

Hi, On Sun, Feb 17, 2013 at 04:16:49PM +0100, Pali Rohár wrote: > I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel > driver ADP1653 is already in upstream kernel. Board code was extracted > from this big camera meego patch: > > https://api.pub.meego.com/public/source/CE:Adaptati

[PATCH] ADP1653 board code for Nokia RX-51

Hello, I'm sending ADP1653 flash torch board code for Nokia RX-51. Kernel driver ADP1653 is already in upstream kernel. Board code was extracted from this big camera meego patch: https://api.pub.meego.com/public/source/CE:Adaptation:N900/kernel-adaptation-n900/linux-2.6-Camera-for-Meego-N900-Adap