Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-12 Thread Alexander E. Patrakov
2013/6/12 Jiang Liu : > Hi Alexander, > In the initially-docked case, the failure is caused by an issue in > the intel sound card driver. Seems something is wrong with reference > count management and it never returns to zero on driver detach. > Could you please help to disable the Intel sound

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-12 Thread Alexander E. Patrakov
2013/6/12 Alexander E. Patrakov : > 2013/6/12 Jiang Liu : >> On Wed 12 Jun 2013 12:51:59 AM CST, Alexander E. Patrakov wrote: >>> In the initially-docked case, it exhibits the following problem: when >>> I press the undock button, only one PCI device disappears, and the >>> "docked" LED does not tu

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Alexander E. Patrakov
2013/6/12 Jiang Liu : > On Wed 12 Jun 2013 12:51:59 AM CST, Alexander E. Patrakov wrote: >> 2013/6/11 Jiang Liu : >>> Hi Alexander, >>> This is much more harder issue to resolve. Let's first work around >>> this >>> issue and check whether other things are OK. The patch below is just a >>> pro

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Jiang Liu
On Wed 12 Jun 2013 12:51:59 AM CST, Alexander E. Patrakov wrote: > 2013/6/11 Jiang Liu : >> Hi Alexander, >> This is much more harder issue to resolve. Let's first work around >> this >> issue and check whether other things are OK. The patch below is just a >> prove of concept, could you pleas

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Jiang Liu
Hi Alexander, This is much more harder issue to resolve. Let's first work around this issue and check whether other things are OK. The patch below is just a prove of concept, could you please help to try it? Regards! Gerry --- diff --git a/drivers/acpi/dock.c b/drivers/acpi/dock.c index a7ba

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Alexander E. Patrakov
2013/6/11 Jiang Liu : > Hi Alexander, > Sorry for the deadlock, I have no machine for testing:( > Below patch should fix the deadlock issue. There is another deadlock: [ 34.316382] acpiphp_glue: found ACPI PCI Hotplug slot 1 at PCI :0a:00 [ 34.316557] acpiphp: Slot [1-1] registered

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Jiang Liu
On Tue 11 Jun 2013 08:15:11 PM CST, Alexander E. Patrakov wrote: > 2013/6/11 Jiang Liu : >> Current ACPI glue logic expects that physical devices are destroyed >> before destroying companion ACPI devices, otherwise it will break the >> ACPI unbind logic and cause following warning messages: >> [ 1

Re: [PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Alexander E. Patrakov
2013/6/11 Jiang Liu : > Current ACPI glue logic expects that physical devices are destroyed > before destroying companion ACPI devices, otherwise it will break the > ACPI unbind logic and cause following warning messages: > [ 185.026073] usb usb5: Oops, 'acpi_handle' corrupt > [ 185.035150] pci 0

[PATCH] ACPIPHP: fix device destroying order issue in handling dock notification

2013-06-11 Thread Jiang Liu
Current ACPI glue logic expects that physical devices are destroyed before destroying companion ACPI devices, otherwise it will break the ACPI unbind logic and cause following warning messages: [ 185.026073] usb usb5: Oops, 'acpi_handle' corrupt [ 185.035150] pci :1b:00.0: Oops, 'acpi_handle'