Re: [Update][PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-13 Thread Aaron Lu
On 06/10/2013 06:18 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: ACPI / scan: Simplify ACPI driver probing > > There is no particular reason why acpi_bus_driver_init() needs to be > a separate function and its location with respect to its only caller, > acpi_device_probe(), m

Re: [PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-10 Thread Rafael J. Wysocki
On Monday, June 10, 2013 09:28:58 PM Aaron Lu wrote: > On 06/10/2013 06:16 AM, Rafael J. Wysocki wrote: > > On Sunday, June 09, 2013 09:54:49 AM Aaron Lu wrote: > >> On 06/09/2013 09:19 AM, Aaron Lu wrote: > >>> On 06/09/2013 06:28 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki >

Re: [PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-10 Thread Aaron Lu
On 06/10/2013 06:16 AM, Rafael J. Wysocki wrote: > On Sunday, June 09, 2013 09:54:49 AM Aaron Lu wrote: >> On 06/09/2013 09:19 AM, Aaron Lu wrote: >>> On 06/09/2013 06:28 AM, Rafael J. Wysocki wrote: From: Rafael J. Wysocki There is no particular reason why acpi_bus_driver_init() ne

[Update][PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-09 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Subject: ACPI / scan: Simplify ACPI driver probing There is no particular reason why acpi_bus_driver_init() needs to be a separate function and its location with respect to its only caller, acpi_device_probe(), makes the code a bit difficult to follow. Besides, it doesn't

Re: [PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-09 Thread Rafael J. Wysocki
On Sunday, June 09, 2013 09:54:49 AM Aaron Lu wrote: > On 06/09/2013 09:19 AM, Aaron Lu wrote: > > On 06/09/2013 06:28 AM, Rafael J. Wysocki wrote: > >> From: Rafael J. Wysocki > >> > >> There is no particular reason why acpi_bus_driver_init() needs to be > >> a separate function and its location

Re: [PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-08 Thread Aaron Lu
On 06/09/2013 09:19 AM, Aaron Lu wrote: > On 06/09/2013 06:28 AM, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> There is no particular reason why acpi_bus_driver_init() needs to be >> a separate function and its location with respect to its only caller, >> acpi_device_probe(), makes th

Re: [PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-08 Thread Aaron Lu
On 06/09/2013 06:28 AM, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is no particular reason why acpi_bus_driver_init() needs to be > a separate function and its location with respect to its only caller, > acpi_device_probe(), makes the code a bit difficult to follow. > > Besides

[PATCH] ACPI / scan: Simplify ACPI driver probing

2013-06-08 Thread Rafael J. Wysocki
From: Rafael J. Wysocki There is no particular reason why acpi_bus_driver_init() needs to be a separate function and its location with respect to its only caller, acpi_device_probe(), makes the code a bit difficult to follow. Besides, it doesn't really make sense to check if 'device' is not NULL