Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-21 Thread Mika Westerberg
On Thu, Jan 21, 2021 at 02:22:43PM +0800, Kai-Heng Feng wrote: > On Tue, Jan 19, 2021 at 6:34 PM Greg Kroah-Hartman > wrote: > > > > On Tue, Jan 19, 2021 at 11:41:59AM +0200, Andy Shevchenko wrote: > > > On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > > > > On Tue, Jan 19, 2021 at

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-20 Thread Kai-Heng Feng
On Tue, Jan 19, 2021 at 6:34 PM Greg Kroah-Hartman wrote: > > On Tue, Jan 19, 2021 at 11:41:59AM +0200, Andy Shevchenko wrote: > > On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > > > On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman > > > wrote: > > > > On Tue, Jan 19, 2021 at 0

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-19 Thread Greg Kroah-Hartman
On Tue, Jan 19, 2021 at 11:41:59AM +0200, Andy Shevchenko wrote: > On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > > On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman > > wrote: > > > On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: > > ... > > > > Who will use OF

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-19 Thread Andy Shevchenko
On Tue, Jan 19, 2021 at 04:41:48PM +0800, Kai-Heng Feng wrote: > On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman > wrote: > > On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: ... > > Who will use OF_MODALIAS and where have you documented it? > > After this lands in mainline, I'

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-19 Thread Kai-Heng Feng
On Tue, Jan 19, 2021 at 4:27 PM Greg Kroah-Hartman wrote: > > On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: > > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > > "compatible" is present") may create two "MODALIAS=" in uevent file if > > conditions are met. > > >

Re: [PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-19 Thread Greg Kroah-Hartman
On Tue, Jan 19, 2021 at 04:15:13PM +0800, Kai-Heng Feng wrote: > Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when > "compatible" is present") may create two "MODALIAS=" in uevent file if > conditions are met. > > This breaks systemd-udevd, which assumes each "key" in uevent file is

[PATCH] ACPI / device_sysfs: Use OF_MODALIAS for "compatible" modalias

2021-01-19 Thread Kai-Heng Feng
Commit 8765c5ba1949 ("ACPI / scan: Rework modalias creation when "compatible" is present") may create two "MODALIAS=" in uevent file if conditions are met. This breaks systemd-udevd, which assumes each "key" in uevent file is unique. The internal implementation of systemd-udevd overwrites the firs