Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-06-26 Thread Robert R. Howell
Hi Rafael On 6/24/19 4:24 AM, Rafael J. Wysocki wrote: > > On Saturday, May 25, 2019 7:31:20 AM CEST Robert R. Howell wrote: >> >>... >>... >> >> I've finally managed to complete a reasonable set of tests on my T100TA >> using your >> 2nd patch from above, and on a 5.1.4 based kernel with ONLY t

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-06-24 Thread Rafael J. Wysocki
On Monday, June 24, 2019 12:51:33 PM CEST Hans de Goede wrote: > Hi Rafael, > > > > > Sorry for the long delay. > > > > I haven't dropped this issue on the floor, I hope that you are still able > > to follow up here. > > > > Can you please test the appended patch instead of the previous one?

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-06-24 Thread Hans de Goede
Hi Rafael, Sorry for the long delay. I haven't dropped this issue on the floor, I hope that you are still able to follow up here. Can you please test the appended patch instead of the previous one? I have found some inconsistencies in the handling of hibernation in the ACPI PM domain and

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-06-24 Thread Rafael J. Wysocki
On Saturday, May 25, 2019 7:31:20 AM CEST Robert R. Howell wrote: > On 5/16/19 5:11 AM, Rafael J. Wysocki wrote: > > > > On Thursday, April 25, 2019 6:38:34 PM CEST Robert R. Howell wrote: > >> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: > >> > >>> On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howel

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-24 Thread Robert R. Howell
On 5/16/19 5:11 AM, Rafael J. Wysocki wrote: > > On Thursday, April 25, 2019 6:38:34 PM CEST Robert R. Howell wrote: >> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: >> >>> On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > > O

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-16 Thread Rafael J. Wysocki
On Thursday, May 16, 2019 6:35:40 PM CEST Robert R. Howell wrote: > Hi Rafael > > > On 5/16/19 5:11 AM, Rafael J. Wysocki wrote: > > > On Thursday, April 25, 2019 6:38:34 PM CEST Robert R. Howell wrote: > >> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: > >> > >>> On Tue, Apr 23, 2019 at 10:03 PM

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-16 Thread Robert R. Howell
Hi Rafael On 5/16/19 5:11 AM, Rafael J. Wysocki wrote: > On Thursday, April 25, 2019 6:38:34 PM CEST Robert R. Howell wrote: >> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: >> >>> On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: >>>

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-16 Thread Robert R. Howell
Hi Hans On 5/13/19 2:41 AM, Hans de Goede wrote: > > Hi Robert, > > On 09-05-19 20:09, Robert R. Howell wrote: >> Hi Hans >> >> On 5/9/19 2:50 AM, Hans de Goede wrote: >> >>> >>> Hi, >>> >>> On 09-05-19 06:24, Robert R. Howell wrote: On 4/30/19 8:39 AM, Hans de Goede wrote: > >> >

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-16 Thread Rafael J. Wysocki
On Thursday, April 25, 2019 6:38:34 PM CEST Robert R. Howell wrote: > On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: > > > On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: > >> > >> On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > >>> > >>> On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-14 Thread Hans de Goede
Hi, On 5/9/19 8:09 PM, Robert R. Howell wrote: Hi Hans On 5/9/19 2:50 AM, Hans de Goede wrote: Hi, On 09-05-19 06:24, Robert R. Howell wrote: On 4/30/19 8:39 AM, Hans de Goede wrote: I've just tried to reproduce the "Error i2c_dw_xfer call while suspended" error on suspend/resume on

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-13 Thread Hans de Goede
Hi Robert, On 09-05-19 20:09, Robert R. Howell wrote: Hi Hans On 5/9/19 2:50 AM, Hans de Goede wrote: Hi, On 09-05-19 06:24, Robert R. Howell wrote: On 4/30/19 8:39 AM, Hans de Goede wrote: I've just tried to reproduce the "Error i2c_dw_xfer call while suspended" error on suspend/res

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-09 Thread Robert R. Howell
Hi Hans On 5/9/19 2:50 AM, Hans de Goede wrote: > > Hi, > > On 09-05-19 06:24, Robert R. Howell wrote: >> On 4/30/19 8:39 AM, Hans de Goede wrote: >>> >>> >>> I've just tried to reproduce the "Error i2c_dw_xfer call while suspended" >>> error >>> on suspend/resume on my own T100TA and I could

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-09 Thread Hans de Goede
Hi, On 09-05-19 06:24, Robert R. Howell wrote: On 4/30/19 8:39 AM, Hans de Goede wrote: Hi, On 4/25/19 6:38 PM, Robert R. Howell wrote: On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: On

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-05-08 Thread Robert R. Howell
On 4/30/19 8:39 AM, Hans de Goede wrote: > > Hi, > > On 4/25/19 6:38 PM, Robert R. Howell wrote: >> On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: >> >>> On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > > On Sat, Apr 20, 2019

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-30 Thread Hans de Goede
Hi, On 4/25/19 6:38 PM, Robert R. Howell wrote: On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: On 4/18/19 5:42 AM, Hans de Goede

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-25 Thread Robert R. Howell
On 4/24/19 1:20 AM, Rafael J. Wysocki wrote: > On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: >> >> On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: >>> >>> On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: On 4/18/19 5:42 AM, Hans de Goede wrote: >> On 4/8/19 2:1

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-24 Thread Rafael J. Wysocki
On Tue, Apr 23, 2019 at 10:03 PM Robert R. Howell wrote: > > On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > > > > On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: > >> > >> On 4/18/19 5:42 AM, Hans de Goede wrote: > >> > On 4/8/19 2:16 AM, Hans de Goede wrote:> > > > > Hmm, i

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-23 Thread Robert R. Howell
On 4/23/19 2:07 AM, Rafael J. Wysocki wrote: > > On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: >> >> On 4/18/19 5:42 AM, Hans de Goede wrote: >> On 4/8/19 2:16 AM, Hans de Goede wrote:> > > Hmm, interesting so you have hibernation working on a T100TA > (with 5.0 + 02e4

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-23 Thread Rafael J. Wysocki
On Sat, Apr 20, 2019 at 12:44 AM Robert R. Howell wrote: > > On 4/18/19 5:42 AM, Hans de Goede wrote: > > >> On 4/8/19 2:16 AM, Hans de Goede wrote:> > >>> > >>> Hmm, interesting so you have hibernation working on a T100TA > >>> (with 5.0 + 02e45646d53b reverted), right ? > >>> > > > Still since m

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-19 Thread Robert R. Howell
On 4/18/19 5:42 AM, Hans de Goede wrote: >> On 4/8/19 2:16 AM, Hans de Goede wrote:> >>> >>> Hmm, interesting so you have hibernation working on a T100TA >>> (with 5.0 + 02e45646d53b reverted), right ? >>> > Still since my patch is regressing things for you I will try to > take a look at this and

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-18 Thread Hans de Goede
Hello Robert, On 11-04-19 21:50, Robert R. Howell wrote: On 4/8/19 2:16 AM, Hans de Goede wrote:> Hmm, interesting so you have hibernation working on a T100TA (with 5.0 + 02e45646d53b reverted), right ? Hi Hans and Kai-Heng First, apologies for how long it took me to reply to both your inqu

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-11 Thread Robert R. Howell
On 4/7/19 9:44 PM, Kai Heng Feng wrote: > at 4:58 AM, Robert R. Howell wrote: > >>> On 03-04-19 07:43, Kai-Heng Feng wrote: i2c-designware-platdrv fails to work after the system restored from hibernation: >> I did try applying your (Hans') patch to a 5.0.0 and a 5.1-rc3 kernel, >> inste

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-11 Thread Robert R. Howell
On 4/8/19 2:16 AM, Hans de Goede wrote:> > > Hmm, interesting so you have hibernation working on a T100TA > (with 5.0 + 02e45646d53b reverted), right ? > Hi Hans and Kai-Heng First, apologies for how long it took me to reply to both your inquiries. In trying to answer them I discovered some i

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-08 Thread Hans de Goede
Hi, On 07-04-19 22:58, Robert R. Howell wrote: On 4/3/19 2:54 AM, Hans de Goede wrote: Hi, On 03-04-19 07:43, Kai-Heng Feng wrote: i2c-designware-platdrv fails to work after the system restored from hibernation: [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0xf

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-07 Thread Kai Heng Feng
at 4:58 AM, Robert R. Howell wrote: On 4/3/19 2:54 AM, Hans de Goede wrote: Hi, On 03-04-19 07:43, Kai-Heng Feng wrote: i2c-designware-platdrv fails to work after the system restored from hibernation: [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0x

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-07 Thread Robert R. Howell
On 4/3/19 2:54 AM, Hans de Goede wrote: > > Hi, > > On 03-04-19 07:43, Kai-Heng Feng wrote: >> i2c-designware-platdrv fails to work after the system restored from >> hibernation: >> [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: >> 0x >> >> Commit 48402cee688

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-03 Thread Hans de Goede
Hi, On 03-04-19 07:43, Kai-Heng Feng wrote: i2c-designware-platdrv fails to work after the system restored from hibernation: [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0x Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from resume_noirq

Re: [PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-03 Thread Jarkko Nikula
On 4/3/19 8:43 AM, Kai-Heng Feng wrote: i2c-designware-platdrv fails to work after the system restored from hibernation: [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0x Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from resume_noirq") ma

[PATCH] ACPI / LPSS: Don't skip late system PM ops for hibernate on BYT/CHT

2019-04-02 Thread Kai-Heng Feng
i2c-designware-platdrv fails to work after the system restored from hibernation: [ 272.775692] i2c_designware 80860F41:00: Unknown Synopsys component type: 0x Commit 48402cee6889 ("ACPI / LPSS: Resume BYT/CHT I2C controllers from resume_noirq") makes acpi_lpss_{suspend_late,resume_early}(