Re: [PATCH] ACPI / CPPC: Fix negative array index read in cppc_set_perf

2017-12-15 Thread Rafael J. Wysocki
On Wednesday, December 13, 2017 11:45:41 PM CET Gustavo A. R. Silva wrote: > If pcc_ss_id is less than 0, there is a negative array index read > before verifying pcc_ss_id is not a negative value. > > Fix this by removing the code that triggers this issue. > > Notice that this code is already pro

Re: [PATCH] ACPI / CPPC: Fix negative array index read in cppc_set_perf

2017-12-15 Thread George Cherian
On Thursday 14 December 2017 04:15 AM, Gustavo A. R. Silva wrote: If pcc_ss_id is less than 0, there is a negative array index read before verifying pcc_ss_id is not a negative value. Fix this by removing the code that triggers this issue. Notice that this code is already properly placed afte

[PATCH] ACPI / CPPC: Fix negative array index read in cppc_set_perf

2017-12-13 Thread Gustavo A. R. Silva
If pcc_ss_id is less than 0, there is a negative array index read before verifying pcc_ss_id is not a negative value. Fix this by removing the code that triggers this issue. Notice that this code is already properly placed after the check on pcc_ss_id at line 1182: pcc_ss_data = pcc_data[pcc_ss_i