Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-07-01 Thread Naresh Bhat
Opps sorry about that. I have added my sign-off and send the patch. Thanks Naresh Bhat On 1 July 2013 19:29, Rafael J. Wysocki wrote: > On Monday, July 01, 2013 05:31:46 PM Naresh Bhat wrote: >> Hi Rafeal, >> >> I appreciate if you give any feedback on the provided patch. > > The patch is OK, bu

[PATCH] ACPI/fan: Initialize acpi_state variable

2013-07-01 Thread naresh . bhat
From: Naresh Bhat CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by: Naresh Bhat --- drivers/acpi/fan.c |2 +- 1 file changed, 1 inserti

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-07-01 Thread Rafael J. Wysocki
On Monday, July 01, 2013 05:31:46 PM Naresh Bhat wrote: > Hi Rafeal, > > I appreciate if you give any feedback on the provided patch. The patch is OK, but please add your sign-off. Thanks, Rafael > On 28 June 2013 01:17, wrote: > > From: Naresh Bhat > > > > CC drivers/acpi/fan.o > >

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-07-01 Thread Naresh Bhat
Hi Rafeal, I appreciate if you give any feedback on the provided patch. Thanks -Naresh Bhat On 28 June 2013 01:17, wrote: > From: Naresh Bhat > > CC drivers/acpi/fan.o > drivers/acpi/fan.c: In function ‘fan_get_cur_state’: > drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used un

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread Naresh Bhat
Done. Thank you very much -Naresh Bhat On 28 June 2013 00:59, Rafael J. Wysocki wrote: > On Thursday, June 27, 2013 06:37:35 PM Naresh Bhat wrote: >> Hi Rafael, >> >> You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ? > > Yes, please. > > Although this is a false positiv

[PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread naresh . bhat
From: Naresh Bhat CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized] --- drivers/acpi/fan.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread Rafael J. Wysocki
On Thursday, June 27, 2013 06:37:35 PM Naresh Bhat wrote: > Hi Rafael, > > You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ? Yes, please. Although this is a false positive anyway ... Thanks, Rafael > On 27 June 2013 17:58, Rafael J. Wysocki wrote: > > On Thursday, Ju

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread Naresh Bhat
Hi Rafael, You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ? Thanks -Naresh Bhat On 27 June 2013 17:58, Rafael J. Wysocki wrote: > On Thursday, June 27, 2013 04:38:34 PM naresh.b...@linaro.org wrote: >> From: Naresh Bhat >> >> CC drivers/acpi/fan.o >> drivers/ac

Re: [PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread Rafael J. Wysocki
On Thursday, June 27, 2013 04:38:34 PM naresh.b...@linaro.org wrote: > From: Naresh Bhat > > CC drivers/acpi/fan.o > drivers/acpi/fan.c: In function ‘fan_get_cur_state’: > drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in > this function [-Wuninitialized] > --- >

[PATCH] ACPI/fan: Initialize acpi_state variable

2013-06-27 Thread naresh . bhat
From: Naresh Bhat CC drivers/acpi/fan.o drivers/acpi/fan.c: In function ‘fan_get_cur_state’: drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized] --- drivers/acpi/fan.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -