Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-16 Thread Lan Tianyu
On 2014年06月17日 09:27, David Rientjes wrote: > On Mon, 16 Jun 2014, Lan Tianyu wrote: > How about this? - result = acpi_battery_update(battery, false); - if (result) + + /* +* Some machines'(E,G Lenovo Z480) ECs are not stable +

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-16 Thread David Rientjes
On Mon, 16 Jun 2014, Lan Tianyu wrote: > >> How about this? > >> > >> - result = acpi_battery_update(battery, false); > >> - if (result) > >> + > >> + /* > >> +* Some machines'(E,G Lenovo Z480) ECs are not stable > >> +* during boot up and this causes battery driv

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-15 Thread Lan Tianyu
ernel.org; nas...@ya.ru; >> linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org >> Subject: Re: [PATCH] ACPI/Battery: Retry to get Battery information if >> failed during probing >> >> On 2014年06月14日 05:46, David Rientjes wrote: >>> On Fri, 13 Ju

RE: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-15 Thread Zheng, Lv
el@vger.kernel.org > Subject: Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed > during probing > > On 2014年06月14日 05:46, David Rientjes wrote: > > On Fri, 13 Jun 2014, Lan Tianyu wrote: > > > >> How about this? > >> > >> -

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-15 Thread Lan Tianyu
On 2014年06月14日 05:46, David Rientjes wrote: > On Fri, 13 Jun 2014, Lan Tianyu wrote: > >> How about this? >> >> - result = acpi_battery_update(battery, false); >> - if (result) >> + >> + /* >> +* Some machines'(E,G Lenovo Z480) ECs are not stable >> +* during boot

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-13 Thread David Rientjes
On Fri, 13 Jun 2014, Lan Tianyu wrote: > How about this? > > - result = acpi_battery_update(battery, false); > - if (result) > + > + /* > +* Some machines'(E,G Lenovo Z480) ECs are not stable > +* during boot up and this causes battery driver fails to be > +

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-12 Thread Lan Tianyu
On 2014年06月13日 05:17, David Rientjes wrote: > On Thu, 12 Jun 2014, Lan Tianyu wrote: > >> The retry time is set by randomly and not accurate because don't know >> when EC will work normally. Set the retry time to 5 just in order to >> make sure battery driver probing sucessfully every time, >> >

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-12 Thread David Rientjes
On Thu, 12 Jun 2014, Lan Tianyu wrote: > The retry time is set by randomly and not accurate because don't know > when EC will work normally. Set the retry time to 5 just in order to > make sure battery driver probing sucessfully every time, > Ok, I was hoping to avoid the excessive wait if it wi

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-12 Thread Lan Tianyu
On 2014年06月12日 15:26, David Rientjes wrote: > On Thu, 12 Jun 2014, Lan Tianyu wrote: > Some machines'(E,G Lenovo Z480) ECs are not stable during boot up and causes battery driver fails to be probed due to failure of getting battery information from EC sometimes. After several retrie

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-12 Thread David Rientjes
On Thu, 12 Jun 2014, Lan Tianyu wrote: > >> Some machines'(E,G Lenovo Z480) ECs are not stable during boot up > >> and causes battery driver fails to be probed due to failure of getting > >> battery information from EC sometimes. After several retries, the > >> operation will work. This patch is t

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-12 Thread Lan Tianyu
On 2014年06月12日 14:55, David Rientjes wrote: > On Thu, 12 Jun 2014, Lan Tianyu wrote: > >> Some machines'(E,G Lenovo Z480) ECs are not stable during boot up >> and causes battery driver fails to be probed due to failure of getting >> battery information from EC sometimes. After several retries, the

Re: [PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-11 Thread David Rientjes
On Thu, 12 Jun 2014, Lan Tianyu wrote: > Some machines'(E,G Lenovo Z480) ECs are not stable during boot up > and causes battery driver fails to be probed due to failure of getting > battery information from EC sometimes. After several retries, the > operation will work. This patch is to retry to g

[PATCH] ACPI/Battery: Retry to get Battery information if failed during probing

2014-06-11 Thread Lan Tianyu
Some machines'(E,G Lenovo Z480) ECs are not stable during boot up and causes battery driver fails to be probed due to failure of getting battery information from EC sometimes. After several retries, the operation will work. This patch is to retry to get battery information 5 times if the first try