RE: [PATCH] 4/4 block: explicit plugging

2007-01-05 Thread Chen, Kenneth W
Andrew Morton wrote on Wednesday, January 03, 2007 12:09 AM > Do you have any benchmarks which got faster with these changes? Jens Axboe wrote on Wednesday, January 03, 2007 12:22 AM > I've asked Ken to run this series on some of his big iron, I hope he'll > have some results for us soonish. I can

Re: [PATCH] 4/4 block: explicit plugging

2007-01-04 Thread Jens Axboe
On Thu, Jan 04 2007, Nick Piggin wrote: > Jens Axboe wrote: > >Nick writes: > > > >This is a patch to perform block device plugging explicitly in the > >submitting > >process context rather than implicitly by the block device. > > Hi Jens, > > Hey thanks for doing so much hard work with this, I

Re: [PATCH] 4/4 block: explicit plugging

2007-01-04 Thread Jens Axboe
On Wed, Jan 03 2007, Chen, Kenneth W wrote: > Jens Axboe wrote on Wednesday, January 03, 2007 2:30 PM > > > We are having some trouble with the patch set that some of our fiber > > > channel > > > host controller doesn't initialize properly anymore and thus lost whole > > > bunch of disks (somewhe

Re: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Nick Piggin
Jens Axboe wrote: Nick writes: This is a patch to perform block device plugging explicitly in the submitting process context rather than implicitly by the block device. Hi Jens, Hey thanks for doing so much hard work with this, I couldn't have fixed all the block layer stuff myself. QRCU look

RE: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Chen, Kenneth W
Jens Axboe wrote on Wednesday, January 03, 2007 2:30 PM > > We are having some trouble with the patch set that some of our fiber channel > > host controller doesn't initialize properly anymore and thus lost whole > > bunch of disks (somewhere around 200 disks out of 900) at boot time. > > Presumabl

Re: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Jens Axboe
On Wed, Jan 03 2007, Chen, Kenneth W wrote: > Jens Axboe wrote on Wednesday, January 03, 2007 12:22 AM > > > Do you have any benchmarks which got faster with these changes? > > > > On the hardware I have immediately available, I see no regressions wrt > > performance. With instrumentation it's sim

RE: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Chen, Kenneth W
Jens Axboe wrote on Wednesday, January 03, 2007 12:22 AM > > Do you have any benchmarks which got faster with these changes? > > On the hardware I have immediately available, I see no regressions wrt > performance. With instrumentation it's simple to demonstrate that most > of the queueing activit

[PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Jens Axboe
Not much luck with the 4th patch, I guess it's too big. I've gzip attached it now, with the description inlined. --- Nick writes: This is a patch to perform block device plugging explicitly in the submitting process context rather than implicitly by the block device. There are several advantag

Re: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Jens Axboe
On Wed, Jan 03 2007, Andrew Morton wrote: > On Wed, 3 Jan 2007 08:48:28 +0100 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > This is a patch to perform block device plugging explicitly in the > > submitting > > process context rather than implicitly by the block device. > > I don't think anyone

Re: [PATCH] 4/4 block: explicit plugging

2007-01-03 Thread Andrew Morton
On Wed, 3 Jan 2007 08:48:28 +0100 Jens Axboe <[EMAIL PROTECTED]> wrote: > This is a patch to perform block device plugging explicitly in the submitting > process context rather than implicitly by the block device. I don't think anyone will regret the passing of address_space_operations.sync_pag