Re: [PATCH] 3 one-liner bugfixes

Manfred Spraul wrote: > > + else > + fl->fl_type & ~F_INPROGRESS; ^^ > + unlock_kernel(); > + return ret; > } The last patch was incorrect. Corrected version attached. -- Manfred // $Header$ // Kernel Version: // VERSION = 2 // PATC

Re: [PATCH] 3 one-liner bugfixes

Linus Torvalds wrote: > > On Sat, 5 May 2001, Manfred Spraul wrote: > > > > * missing/wrong lock_kernel calls in fs/fcntl.c: getlk/setlk run without > > the big kernel lock. The ..64 function acquire the lock. > > This is wrong. The big lock (if it is needed, but I thought the current > locking

Re: [PATCH] 3 one-liner bugfixes

On Sat, 5 May 2001, Manfred Spraul wrote: > > * missing/wrong lock_kernel calls in fs/fcntl.c: getlk/setlk run without > the big kernel lock. The ..64 function acquire the lock. This is wrong. The big lock (if it is needed, but I thought the current locking should be safe) should be pushed down

[PATCH] 3 one-liner bugfixes

Hi Linus, I found a 3 small bugs: * mm/slab.c: the offslab_limit calculation used 2 instead of sizeof(kmem_bufctl_t) [==4]. Cosmetic bug, since offslab_limit is never reached. * expand_stack is not down_read() safe, but used in the page-in path. Fix is trivial. * missing/wrong lock_kernel call