Re: [PATCH] 2/6 i386 serialize-msr

2005-07-30 Thread Zachary Amsden
'Apparently' I need to make some coffee :) Zwane Mwaikambo wrote: wrmsr(MSR_IA32_UCODE_REV, 0, 0); - __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx"); + /* see 1.07. Apprent chip bug */ + serialize_cpu(); 1.07 in which document? Also, please just spell 'apparen

Re: [PATCH] 2/6 i386 serialize-msr

2005-07-30 Thread Zwane Mwaikambo
wrmsr(MSR_IA32_UCODE_REV, 0, 0); - __asm__ __volatile__ ("cpuid" : : : "ax", "bx", "cx", "dx"); + /* see 1.07. Apprent chip bug */ + serialize_cpu(); 1.07 in which document? Also, please just spell 'apparent' correctly, saving 1 byte really just looks lazy. - To unsubs

Re: [PATCH] 2/6 i386 serialize-msr

2005-07-30 Thread Zachary Amsden
Pavel Machek wrote: Hi! i386 arch cleanup. Introduce the serialize macro to serialize processor state. Why the microcode update needs it I am not quite sure, since wrmsr() is already a serializing instruction, but it is a microcode update, so I will keep the semantic the same, since this c

Re: [PATCH] 2/6 i386 serialize-msr

2005-07-30 Thread Pavel Machek
Hi! > i386 arch cleanup. Introduce the serialize macro to serialize processor > state. > Why the microcode update needs it I am not quite sure, since wrmsr() is > already > a serializing instruction, but it is a microcode update, so I will keep the > semantic the same, since this could be a tim

[PATCH] 2/6 i386 serialize-msr

2005-07-29 Thread zach
i386 arch cleanup. Introduce the serialize macro to serialize processor state. Why the microcode update needs it I am not quite sure, since wrmsr() is already a serializing instruction, but it is a microcode update, so I will keep the semantic the same, since this could be a timing workaround. As