Re: [PATCH] fs/ceph: make logical calculation functions return bool

2016-03-25 Thread Al Viro
On Fri, Mar 25, 2016 at 04:42:45PM +0800, Zhang Zhuoyu wrote: > > This one is for ilookup5. ilookup5() wants function pointer "int > > (*test)(struct > > inode *, void *)”. The rest change looks good. > > > > Regards > > Yan, Zheng > > > > Yes, you are right, I will send another version. ...

RE: [PATCH] fs/ceph: make logical calculation functions return bool

2016-03-25 Thread Zhang Zhuoyu
> -Original Message- > From: Yan, Zheng [mailto:z...@redhat.com] > Sent: Friday, March 25, 2016 4:32 PM > To: Zhang Zhuoyu > Cc: Ceph Development ; Sage Weil > ; idryo...@gmail.com; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] fs/ceph: make logical calcula

Re: [PATCH] fs/ceph: make logical calculation functions return bool

2016-03-25 Thread Yan, Zheng
> On Mar 25, 2016, at 14:19, Zhang Zhuoyu > wrote: > > This patch makes serverl logical caculation functions return bool to > improve readability due to these particular functions only using 0/1 as > their return value. > > No functional change. > > Signed-off-by: Zhang Zhuoyu > --- > fs/cep

[PATCH] fs/ceph: make logical calculation functions return bool

2016-03-24 Thread Zhang Zhuoyu
This patch makes serverl logical caculation functions return bool to improve readability due to these particular functions only using 0/1 as their return value. No functional change. Signed-off-by: Zhang Zhuoyu --- fs/ceph/cache.c| 2 +- fs/ceph/dir.c | 2