Re: Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()

2020-05-31 Thread dinghao . liu
Hi, Markus, > * How do you think about to replace the word “pairing” by “corresponding”? > > * Will it be helpful to add an imperative wording? > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=ffeb595d84811dde16a28b33

Re: [PATCH v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error in lpi2c_imx_master_enable()

2020-05-31 Thread Markus Elfring
> pm_runtime_get_sync() increments the runtime PM usage counter even > the call returns an error code. Thus a pairing decrement is needed > on the error handling path to keep the counter balanced. * How do you think about to replace the word “pairing” by “corresponding”? * Will it be helpful to a

[PATCH] [v2] i2c: imx-lpi2c: Fix runtime PM imbalance on error

2020-05-30 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- Changelog: v2: - Use pm_runtime_put_noidle() instead of pm_runtime_p