Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-09-16 Thread Sameer Pujar
Sorry for the delay in replying. On 8/20/2019 4:35 PM, Vinod Koul wrote: On 19-08-19, 16:56, Jon Hunter wrote: On this, I am inclined to think that dma driver should not be involved. The ADMAIF needs this configuration and we should take the path of dma_router for this piece and add features li

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-08-20 Thread Vinod Koul
On 19-08-19, 16:56, Jon Hunter wrote: > >>> On this, I am inclined to think that dma driver should not be > >>> involved. > >>> The ADMAIF needs this configuration and we should take the path of > >>> dma_router for this piece and add features like this to it > >> > >> Hi V

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-08-19 Thread Jon Hunter
On 08/08/2019 13:38, Vinod Koul wrote: > On 02-08-19, 09:51, Jon Hunter wrote: >> >> On 31/07/2019 16:16, Vinod Koul wrote: >>> On 31-07-19, 10:48, Jon Hunter wrote: On 29/07/2019 07:10, Vinod Koul wrote: > On 23-07-19, 11:24, Sameer Pujar wrote: >> >> On 7/19/2019 10:34 AM,

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-08-08 Thread Vinod Koul
On 02-08-19, 09:51, Jon Hunter wrote: > > On 31/07/2019 16:16, Vinod Koul wrote: > > On 31-07-19, 10:48, Jon Hunter wrote: > >> > >> On 29/07/2019 07:10, Vinod Koul wrote: > >>> On 23-07-19, 11:24, Sameer Pujar wrote: > > On 7/19/2019 10:34 AM, Vinod Koul wrote: > > On 05-07-19, 11:4

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-08-02 Thread Jon Hunter
On 31/07/2019 16:16, Vinod Koul wrote: > On 31-07-19, 10:48, Jon Hunter wrote: >> >> On 29/07/2019 07:10, Vinod Koul wrote: >>> On 23-07-19, 11:24, Sameer Pujar wrote: On 7/19/2019 10:34 AM, Vinod Koul wrote: > On 05-07-19, 11:45, Sameer Pujar wrote: >> Hi Vinod, >> >> W

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-31 Thread Vinod Koul
On 31-07-19, 10:48, Jon Hunter wrote: > > On 29/07/2019 07:10, Vinod Koul wrote: > > On 23-07-19, 11:24, Sameer Pujar wrote: > >> > >> On 7/19/2019 10:34 AM, Vinod Koul wrote: > >>> On 05-07-19, 11:45, Sameer Pujar wrote: > Hi Vinod, > > What are your final thoughts regarding this?

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-31 Thread Jon Hunter
On 29/07/2019 07:10, Vinod Koul wrote: > On 23-07-19, 11:24, Sameer Pujar wrote: >> >> On 7/19/2019 10:34 AM, Vinod Koul wrote: >>> On 05-07-19, 11:45, Sameer Pujar wrote: Hi Vinod, What are your final thoughts regarding this? >>> Hi sameer, >>> >>> Sorry for the delay in replying

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-28 Thread Vinod Koul
On 23-07-19, 11:24, Sameer Pujar wrote: > > On 7/19/2019 10:34 AM, Vinod Koul wrote: > > On 05-07-19, 11:45, Sameer Pujar wrote: > > > Hi Vinod, > > > > > > What are your final thoughts regarding this? > > Hi sameer, > > > > Sorry for the delay in replying > > > > On this, I am inclined to thin

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-22 Thread Sameer Pujar
On 7/19/2019 10:34 AM, Vinod Koul wrote: On 05-07-19, 11:45, Sameer Pujar wrote: Hi Vinod, What are your final thoughts regarding this? Hi sameer, Sorry for the delay in replying On this, I am inclined to think that dma driver should not be involved. The ADMAIF needs this configuration and

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-18 Thread Vinod Koul
On 05-07-19, 11:45, Sameer Pujar wrote: > Hi Vinod, > > What are your final thoughts regarding this? Hi sameer, Sorry for the delay in replying On this, I am inclined to think that dma driver should not be involved. The ADMAIF needs this configuration and we should take the path of dma_router f

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-15 Thread Sameer Pujar
Hi Vinod, Sorry for writing again. Can we please conclude on this? Thanks, Sameer. On 7/5/2019 11:45 AM, Sameer Pujar wrote: Hi Vinod, What are your final thoughts regarding this? Thanks, Sameer. Where does ADMAIF driver reside in kernel, who configures it for normal dma txns..? Not yet,

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-07-04 Thread Sameer Pujar
Hi Vinod, What are your final thoughts regarding this? Thanks, Sameer. Where does ADMAIF driver reside in kernel, who configures it for normal dma txns..? Not yet, we are in the process of upstreaming ADMAIF driver. To describe briefly, audio subsystem is using ALSA SoC(ASoC) layer. ADMAIF i

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-24 Thread Sameer Pujar
On 6/24/2019 11:56 AM, Vinod Koul wrote: On 20-06-19, 15:59, Sameer Pujar wrote: So can you explain me what is the difference here that the peripheral cannot configure and use burst size with passing fifo depth? Say for example FIFO_THRESHOLD is programmed as 16 WORDS, BURST_SIZE as 8 WORDS.

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-23 Thread Vinod Koul
On 20-06-19, 15:59, Sameer Pujar wrote: > > > > So can you explain me what is the difference here that the peripheral > > > > cannot configure and use burst size with passing fifo depth? > > > Say for example FIFO_THRESHOLD is programmed as 16 WORDS, BURST_SIZE as 8 > > > WORDS. > > > ADMAIF does

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-20 Thread Sameer Pujar
On 6/18/2019 10:03 AM, Vinod Koul wrote: On 17-06-19, 12:37, Sameer Pujar wrote: On 6/13/2019 10:13 AM, Vinod Koul wrote: On 06-06-19, 09:19, Sameer Pujar wrote: you are really going other way around about the whole picture. FWIW that is how *other* folks do audio with dmaengine! I discuss

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-17 Thread Vinod Koul
On 17-06-19, 12:37, Sameer Pujar wrote: > > On 6/13/2019 10:13 AM, Vinod Koul wrote: > > On 06-06-19, 09:19, Sameer Pujar wrote: > > > > > > you are really going other way around about the whole picture. FWIW that > > > > is how *other* folks do audio with dmaengine! > > > I discussed this intern

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-17 Thread Sameer Pujar
On 6/13/2019 10:13 AM, Vinod Koul wrote: On 06-06-19, 09:19, Sameer Pujar wrote: you are really going other way around about the whole picture. FWIW that is how *other* folks do audio with dmaengine! I discussed this internally with HW folks and below is the reason why DMA needs to know FIFO

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-13 Thread Vinod Koul
On 06-06-19, 09:19, Sameer Pujar wrote: > > you are really going other way around about the whole picture. FWIW that > > is how *other* folks do audio with dmaengine! > I discussed this internally with HW folks and below is the reason why DMA > needs > to know FIFO size. > > - FIFOs reside in per

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-10 Thread Jon Hunter
On 07/06/2019 21:53, Dmitry Osipenko wrote: > 07.06.2019 16:35, Peter Ujfalusi пишет: >> >> >> On 07/06/2019 15.58, Jon Hunter wrote: Imho if you can explain it without using 'HACK' in the sentences it might be OK, but it does not feel right. >>> >>> I don't perceive this as a hack. Alt

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-10 Thread Jon Hunter
On 07/06/2019 14:35, Peter Ujfalusi wrote: > > > On 07/06/2019 15.58, Jon Hunter wrote: >>> Imho if you can explain it without using 'HACK' in the sentences it >>> might be OK, but it does not feel right. >> >> I don't perceive this as a hack. Although from looking at the >> description of the

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Dmitry Osipenko
07.06.2019 16:35, Peter Ujfalusi пишет: > > > On 07/06/2019 15.58, Jon Hunter wrote: >>> Imho if you can explain it without using 'HACK' in the sentences it >>> might be OK, but it does not feel right. >> >> I don't perceive this as a hack. Although from looking at the >> description of the src/d

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Peter Ujfalusi
On 07/06/2019 15.58, Jon Hunter wrote: >> Imho if you can explain it without using 'HACK' in the sentences it >> might be OK, but it does not feel right. > > I don't perceive this as a hack. Although from looking at the > description of the src/dst_maxburst these are burst size with regard to >

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Jon Hunter
On 07/06/2019 13:17, Peter Ujfalusi wrote: > > > On 07/06/2019 13.27, Jon Hunter wrote: Hrm, it is still not clear how all of these fits together. What happens if you configure ADMA side: BURST = 10 TX/RXSIZE = 100 (100 * 64 bytes?) /* FIFO_SIZE? */ *THRES = 5

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Peter Ujfalusi
On 07/06/2019 13.27, Jon Hunter wrote: >>> Hrm, it is still not clear how all of these fits together. >>> >>> What happens if you configure ADMA side: >>> BURST = 10 >>> TX/RXSIZE = 100 (100 * 64 bytes?) /* FIFO_SIZE? */ >>> *THRES = 5 >>> >>> And if you change the *THRES to 10? >>> And if you c

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Jon Hunter
On 07/06/2019 10:18, Jon Hunter wrote: > > On 07/06/2019 06:50, Peter Ujfalusi wrote: >> Jon, >> >> On 06/06/2019 15.37, Jon Hunter wrote: Looking at the drivers/dma/tegra210-adma.c for the TEGRA*_FIFO_CTRL_DEFAULT definition it is still not clear where the remote FIFO size would

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Jon Hunter
On 06/06/2019 18:25, Dmitry Osipenko wrote: > 06.06.2019 19:53, Jon Hunter пишет: >> >> On 06/06/2019 17:44, Dmitry Osipenko wrote: >>> 06.06.2019 19:32, Jon Hunter пишет: On 06/06/2019 16:18, Dmitry Osipenko wrote: ... >>> If I understood everything correctly, the FI

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Jon Hunter
On 07/06/2019 06:50, Peter Ujfalusi wrote: > Jon, > > On 06/06/2019 15.37, Jon Hunter wrote: >>> Looking at the drivers/dma/tegra210-adma.c for the >>> TEGRA*_FIFO_CTRL_DEFAULT definition it is still not clear where the >>> remote FIFO size would fit. >>> There are fields for overflow and starva

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-07 Thread Peter Ujfalusi
Jon, On 06/06/2019 15.37, Jon Hunter wrote: >> Looking at the drivers/dma/tegra210-adma.c for the >> TEGRA*_FIFO_CTRL_DEFAULT definition it is still not clear where the >> remote FIFO size would fit. >> There are fields for overflow and starvation(?) thresholds and TX/RX >> size (assuming word len

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 20:25, Dmitry Osipenko пишет: > 06.06.2019 19:53, Jon Hunter пишет: >> >> On 06/06/2019 17:44, Dmitry Osipenko wrote: >>> 06.06.2019 19:32, Jon Hunter пишет: On 06/06/2019 16:18, Dmitry Osipenko wrote: ... >>> If I understood everything correctly, the FIFO bu

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 19:53, Jon Hunter пишет: > > On 06/06/2019 17:44, Dmitry Osipenko wrote: >> 06.06.2019 19:32, Jon Hunter пишет: >>> >>> On 06/06/2019 16:18, Dmitry Osipenko wrote: >>> >>> ... >>> >> If I understood everything correctly, the FIFO buffer is shared among >> all of the ADMA clients

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 17:44, Dmitry Osipenko wrote: > 06.06.2019 19:32, Jon Hunter пишет: >> >> On 06/06/2019 16:18, Dmitry Osipenko wrote: >> >> ... >> > If I understood everything correctly, the FIFO buffer is shared among > all of the ADMA clients and hence it should be up to the ADMA driver t

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 19:32, Jon Hunter пишет: > > On 06/06/2019 16:18, Dmitry Osipenko wrote: > > ... > If I understood everything correctly, the FIFO buffer is shared among all of the ADMA clients and hence it should be up to the ADMA driver to manage the quotas of the clients. So if there

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 16:18, Dmitry Osipenko wrote: ... >>> If I understood everything correctly, the FIFO buffer is shared among >>> all of the ADMA clients and hence it should be up to the ADMA driver to >>> manage the quotas of the clients. So if there is only one client that >>> uses ADMA at a time

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 17:25, Jon Hunter пишет: > > > On 06/06/2019 14:45, Dmitry Osipenko wrote: >> 06.06.2019 15:37, Jon Hunter пишет: >>> >>> On 06/06/2019 12:54, Peter Ujfalusi wrote: On 06/06/2019 13.49, Jon Hunter wrote: > > On 06/06/2019 11:22, Peter Ujfalusi wrote: > >

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 15:36, Dmitry Osipenko wrote: > 06.06.2019 17:26, Jon Hunter пишет: >> >> On 06/06/2019 14:55, Dmitry Osipenko wrote: >>> 06.06.2019 16:45, Dmitry Osipenko пишет: 06.06.2019 15:37, Jon Hunter пишет: > > On 06/06/2019 12:54, Peter Ujfalusi wrote: >> >> >> On

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 17:26, Jon Hunter пишет: > > On 06/06/2019 14:55, Dmitry Osipenko wrote: >> 06.06.2019 16:45, Dmitry Osipenko пишет: >>> 06.06.2019 15:37, Jon Hunter пишет: On 06/06/2019 12:54, Peter Ujfalusi wrote: > > > On 06/06/2019 13.49, Jon Hunter wrote: >> >> On 06/

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 15:26, Jon Hunter wrote: ... >>> If I understood everything correctly, the FIFO buffer is shared among >>> all of the ADMA clients and hence it should be up to the ADMA driver to >>> manage the quotas of the clients. So if there is only one client that >>> uses ADMA at a time, the

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 14:55, Dmitry Osipenko wrote: > 06.06.2019 16:45, Dmitry Osipenko пишет: >> 06.06.2019 15:37, Jon Hunter пишет: >>> >>> On 06/06/2019 12:54, Peter Ujfalusi wrote: On 06/06/2019 13.49, Jon Hunter wrote: > > On 06/06/2019 11:22, Peter Ujfalusi wrote: > >

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 14:45, Dmitry Osipenko wrote: > 06.06.2019 15:37, Jon Hunter пишет: >> >> On 06/06/2019 12:54, Peter Ujfalusi wrote: >>> >>> >>> On 06/06/2019 13.49, Jon Hunter wrote: On 06/06/2019 11:22, Peter Ujfalusi wrote: ... It does sounds like that FIFO_SIZ

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 16:45, Dmitry Osipenko пишет: > 06.06.2019 15:37, Jon Hunter пишет: >> >> On 06/06/2019 12:54, Peter Ujfalusi wrote: >>> >>> >>> On 06/06/2019 13.49, Jon Hunter wrote: On 06/06/2019 11:22, Peter Ujfalusi wrote: ... It does sounds like that FIFO_SIZE == s

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Dmitry Osipenko
06.06.2019 15:37, Jon Hunter пишет: > > On 06/06/2019 12:54, Peter Ujfalusi wrote: >> >> >> On 06/06/2019 13.49, Jon Hunter wrote: >>> >>> On 06/06/2019 11:22, Peter Ujfalusi wrote: >>> >>> ... >>> >>> It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as >>> well. >>

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 12:54, Peter Ujfalusi wrote: > > > On 06/06/2019 13.49, Jon Hunter wrote: >> >> On 06/06/2019 11:22, Peter Ujfalusi wrote: >> >> ... >> >> It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as >> well. > Not exactly equal. > ADMA burst_size can ran

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Peter Ujfalusi
On 06/06/2019 13.49, Jon Hunter wrote: > > On 06/06/2019 11:22, Peter Ujfalusi wrote: > > ... > > It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as > well. Not exactly equal. ADMA burst_size can range from 1(WORD) to 16(WORDS) FIFO_SIZE can be adjus

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 11:22, Peter Ujfalusi wrote: ... It does sounds like that FIFO_SIZE == src/dst_maxburst in your case as well. >>> Not exactly equal. >>> ADMA burst_size can range from 1(WORD) to 16(WORDS) >>> FIFO_SIZE can be adjusted from 16(WORDS) to 1024(WORDS) [can vary in >>> multi

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Peter Ujfalusi
Hi Jon, Sameer, On 06/06/2019 10.14, Jon Hunter wrote: > > On 06/06/2019 07:41, Sameer Pujar wrote: >> >> On 6/6/2019 11:30 AM, Peter Ujfalusi wrote: >>> Hi Sameer, >>> >>> On 06/06/2019 6.49, Sameer Pujar wrote: Sorry for late reply. [Resending the reply since delivery failed for few r

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-06 Thread Jon Hunter
On 06/06/2019 07:41, Sameer Pujar wrote: > > On 6/6/2019 11:30 AM, Peter Ujfalusi wrote: >> Hi Sameer, >> >> On 06/06/2019 6.49, Sameer Pujar wrote: >>> Sorry for late reply. >>> [Resending the reply since delivery failed for few recipients] >>> I discussed this internally with HW folks and belo

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-05 Thread Sameer Pujar
On 6/6/2019 11:30 AM, Peter Ujfalusi wrote: Hi Sameer, On 06/06/2019 6.49, Sameer Pujar wrote: Sorry for late reply. [Resending the reply since delivery failed for few recipients] I discussed this internally with HW folks and below is the reason why DMA needs to know FIFO size. - FIFOs resid

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-05 Thread Peter Ujfalusi
Hi Sameer, On 06/06/2019 6.49, Sameer Pujar wrote: > Sorry for late reply. > [Resending the reply since delivery failed for few recipients] > I discussed this internally with HW folks and below is the reason why > DMA needs > to know FIFO size. > > - FIFOs reside in peripheral device(ADMAIF), whi

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-06-05 Thread Sameer Pujar
Sorry for late reply. [Resending the reply since delivery failed for few recipients] On 5/6/2019 9:20 PM, Vinod Koul wrote: On 06-05-19, 18:34, Sameer Pujar wrote: On 5/4/2019 3:53 PM, Vinod Koul wrote: On 02-05-19, 18:59, Sameer Pujar wrote: On 5/2/2019 5:55 PM, Vinod Koul wrote: On 02-05-1

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-06 Thread Vinod Koul
On 06-05-19, 18:34, Sameer Pujar wrote: > > On 5/4/2019 3:53 PM, Vinod Koul wrote: > > On 02-05-19, 18:59, Sameer Pujar wrote: > > > On 5/2/2019 5:55 PM, Vinod Koul wrote: > > > > On 02-05-19, 16:23, Sameer Pujar wrote: > > > > > On 5/2/2019 11:34 AM, Vinod Koul wrote: > > > > > > On 30-04-19, 17:

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-06 Thread Sameer Pujar
On 5/4/2019 3:53 PM, Vinod Koul wrote: On 02-05-19, 18:59, Sameer Pujar wrote: On 5/2/2019 5:55 PM, Vinod Koul wrote: On 02-05-19, 16:23, Sameer Pujar wrote: On 5/2/2019 11:34 AM, Vinod Koul wrote: On 30-04-19, 17:00, Sameer Pujar wrote: During the DMA transfers from memory to I/O, it was

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-04 Thread Vinod Koul
On 02-05-19, 18:59, Sameer Pujar wrote: > > On 5/2/2019 5:55 PM, Vinod Koul wrote: > > On 02-05-19, 16:23, Sameer Pujar wrote: > > > On 5/2/2019 11:34 AM, Vinod Koul wrote: > > > > On 30-04-19, 17:00, Sameer Pujar wrote: > > > > > During the DMA transfers from memory to I/O, it was observed that

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-03 Thread Peter Ujfalusi
On 5/2/19 4:29 PM, Sameer Pujar wrote: > > On 5/2/2019 5:55 PM, Vinod Koul wrote: >> On 02-05-19, 16:23, Sameer Pujar wrote: >>> On 5/2/2019 11:34 AM, Vinod Koul wrote: On 30-04-19, 17:00, Sameer Pujar wrote: > During the DMA transfers from memory to I/O, it was observed that > tra

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-02 Thread Sameer Pujar
On 5/2/2019 5:55 PM, Vinod Koul wrote: On 02-05-19, 16:23, Sameer Pujar wrote: On 5/2/2019 11:34 AM, Vinod Koul wrote: On 30-04-19, 17:00, Sameer Pujar wrote: During the DMA transfers from memory to I/O, it was observed that transfers were inconsistent and resulted in glitches for audio play

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-02 Thread Vinod Koul
On 02-05-19, 16:23, Sameer Pujar wrote: > > On 5/2/2019 11:34 AM, Vinod Koul wrote: > > On 30-04-19, 17:00, Sameer Pujar wrote: > > > During the DMA transfers from memory to I/O, it was observed that > > > transfers > > > were inconsistent and resulted in glitches for audio playback. It happened

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-02 Thread Sameer Pujar
On 5/2/2019 11:34 AM, Vinod Koul wrote: On 30-04-19, 17:00, Sameer Pujar wrote: During the DMA transfers from memory to I/O, it was observed that transfers were inconsistent and resulted in glitches for audio playback. It happened because fifo size on DMA did not match with slave channel confi

Re: [PATCH] [RFC] dmaengine: add fifo_size member

2019-05-01 Thread Vinod Koul
On 30-04-19, 17:00, Sameer Pujar wrote: > During the DMA transfers from memory to I/O, it was observed that transfers > were inconsistent and resulted in glitches for audio playback. It happened > because fifo size on DMA did not match with slave channel configuration. > > currently 'dma_slave_con

[PATCH] [RFC] dmaengine: add fifo_size member

2019-04-30 Thread Sameer Pujar
During the DMA transfers from memory to I/O, it was observed that transfers were inconsistent and resulted in glitches for audio playback. It happened because fifo size on DMA did not match with slave channel configuration. currently 'dma_slave_config' structure does not have a field for fifo size