Re: [PATCH] [RESEND] PIE executable randomization

2007-08-15 Thread Jiri Kosina
On Wed, 15 Aug 2007, Chuck Ebbert wrote: > But your patch is enabling randomization for x86_64, because CONFIG_X86 > includes both 32 and 64 bit archs. Hi Chuck, yes, and this is addressed by the second patch I have sent yesterday, which enables flexmmap for x86_64. -- Jiri Kosina SUSE Labs

Re: [PATCH] [RESEND] PIE executable randomization

2007-08-15 Thread Chuck Ebbert
On 08/14/2007 04:41 PM, Jiri Kosina wrote: > (added Arjan to CC, as he has been working on the kernel part of the > randomization previously) > > On Tue, 14 Aug 2007, Jakub Jelinek wrote: > >> If I'm reading the above hunk correctly, this means we will randomize >> all PIEs and even all dynamic

Re: [PATCH] [RESEND] PIE executable randomization

2007-08-15 Thread Kees Cook
Hi, On Wed, Aug 15, 2007 at 01:21:37AM +0200, Jiri Kosina wrote: > The following patch fixes the brk-allocation problems on x86_64 with code > randomization patch on PIE-compiled binaries. Is anyone aware of any > potential disaster it might cause somewhere please? (Adding myself to this thread

Re: [PATCH] [RESEND] PIE executable randomization

2007-08-14 Thread Jiri Kosina
On Tue, 14 Aug 2007, Jiri Kosina wrote: > It turned out recently that PIE-compiled binaries on x86_64, that > perform larger amount of brk-allocations (for example bash) will not > work (but they will work on ?86). This is because currently on ?86 the > memory layout is as follows: (Andi added

Re: [PATCH] [RESEND] PIE executable randomization

2007-08-14 Thread Jiri Kosina
(added Arjan to CC, as he has been working on the kernel part of the randomization previously) On Tue, 14 Aug 2007, Jakub Jelinek wrote: > If I'm reading the above hunk correctly, this means we will randomize > all PIEs and even all dynamic linkers invoked as executables on i?86 and > x86_64,

Re: [PATCH] [RESEND] PIE executable randomization

2007-08-14 Thread Jakub Jelinek
On Wed, Aug 08, 2007 at 04:03:07PM +0200, Jiri Kosina wrote: > @@ -870,11 +917,15 @@ static int load_elf_binary(struct linux_binprm *bprm, > struct pt_regs *regs) >* default mmap base, as well as whatever program they >* might try to exec. This is b

[PATCH] [RESEND] PIE executable randomization

2007-08-08 Thread Jiri Kosina
Hi Andrew, below is a respin of the patch for executable code address randomization of PIE binaries, which already went through -mm into 2.6.22, but then got reverted because of bugreports stating that klibc binaries segfault due to this patch. However it turned out that this was bug in klibc 1