Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-30 Thread Andi Kleen
On Friday 21 September 2007 23:19:35 Jakub Jelinek wrote: > On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote: > > > > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also > > the stack can be already unaligned so letting the compiler align > > is useless. This may make som

Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-21 Thread Dave Jones
On Sat, Sep 22, 2007 at 12:34:31AM +0200, Andi Kleen wrote: > On Friday 21 September 2007 23:13, Dave Jones wrote: > > On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote: > > > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also > > > the stack can be already unaligned

Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-21 Thread Andi Kleen
On Friday 21 September 2007 23:13, Dave Jones wrote: > On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote: > > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also > > the stack can be already unaligned so letting the compiler align > > is useless. This may make some stack

Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-21 Thread Jakub Jelinek
On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote: > > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also > the stack can be already unaligned so letting the compiler align > is useless. This may make some stack frames smaller. Shouldn't sources that are compiled into th

Re: [PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-21 Thread Dave Jones
On Fri, Sep 21, 2007 at 10:45:02PM +0200, Andi Kleen wrote: > > Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also > the stack can be already unaligned so letting the compiler align > is useless. This may make some stack frames smaller. > Only works with very recent gcc 4.3

[PATCH] [20/45] x86_64: Use 8 byte stack alignment when possible

2007-09-21 Thread Andi Kleen
Kernel doesn't use SSE2, so it doesn't need 16 byte alignment. Also the stack can be already unaligned so letting the compiler align is useless. This may make some stack frames smaller. Only works with very recent gcc 4.3 Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86_64/Makefile |