Re: [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD

2008-02-09 Thread Andi Kleen
On Sat, Feb 09, 2008 at 11:28:01AM +0100, Thomas Gleixner wrote: > On Fri, 8 Feb 2008, Andi Kleen wrote: > > > > > Minor logic fix. The century change was previously always BCD, > > even when the CMOS data would report itself not being BCD. > > Where was it previously always BCD ? > > The code

Re: [PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD

2008-02-09 Thread Thomas Gleixner
On Fri, 8 Feb 2008, Andi Kleen wrote: > > Minor logic fix. The century change was previously always BCD, > even when the CMOS data would report itself not being BCD. Where was it previously always BCD ? The code flow is taken 1:1 from the original x8664 code. Just the BCD_TO_BIN code has been m

[PATCH] [1/3] Only do century BCD conversion when we know the RTC is BCD

2008-02-08 Thread Andi Kleen
Minor logic fix. The century change was previously always BCD, even when the CMOS data would report itself not being BCD. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]> --- arch/x86/kernel/rtc.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux/arch/x86/kernel/rtc.c