RE: [PATCH] /dev/zero: also implement ->read

2020-09-07 Thread David Laight
From: Christophe Leroy > Sent: 07 September 2020 05:44 ... > If you are talking about the tests around the set_fs series from > Christoph, I identified that the degradation was linked to > CONFIG_STACKPROTECTOR_STRONG being selected by default, which provides > unreliable results from one patch to

Re: [PATCH] /dev/zero: also implement ->read

2020-09-07 Thread Christoph Hellwig
On Mon, Sep 07, 2020 at 08:50:53AM +0200, Rasmus Villemoes wrote: > > Actually, while you're micro-optimizing it, AFAIK VFS already handles > count==0, It doesn't.

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Rasmus Villemoes
On 07/09/2020 08.20, Christoph Hellwig wrote: > On Mon, Sep 07, 2020 at 12:34:37AM +0200, Rasmus Villemoes wrote: >> On 03/09/2020 17.59, Christoph Hellwig wrote: > >>> +static ssize_t read_zero(struct file *file, char __user *buf, >>> +size_t count, loff_t *ppos) >>> +{ >>> +

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Christoph Hellwig
On Mon, Sep 07, 2020 at 12:34:37AM +0200, Rasmus Villemoes wrote: > On 03/09/2020 17.59, Christoph Hellwig wrote: > > Christophe reported a major speedup due to avoiding the iov_iter > > overhead, so just add this trivial function. Note that /dev/zero > > already implements both an iter and non-it

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Christophe Leroy
Le 06/09/2020 à 22:52, David Laight a écrit : From: Christophe Leroy Sent: 06 September 2020 19:36 Hi, Le 06/09/2020 à 20:21, Pavel Machek a écrit : Hi! Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero alrea

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Rasmus Villemoes
On 03/09/2020 17.59, Christoph Hellwig wrote: > Christophe reported a major speedup due to avoiding the iov_iter > overhead, so just add this trivial function. Note that /dev/zero > already implements both an iter and non-iter writes so this just > makes it more symmetric. > > Christophe Leroy

RE: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread David Laight
From: Christophe Leroy > Sent: 06 September 2020 19:36 > Hi, > > Le 06/09/2020 à 20:21, Pavel Machek a écrit : > > Hi! > > > Christophe reported a major speedup due to avoiding the iov_iter > overhead, so just add this trivial function. Note that /dev/zero > already implements both

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread gre...@linuxfoundation.org
On Sun, Sep 06, 2020 at 08:38:20PM +0200, Pavel Machek wrote: > On Sun 2020-09-06 20:35:38, Christophe Leroy wrote: > > Hi, > > > > Le 06/09/2020 à 20:21, Pavel Machek a écrit : > > >Hi! > > > > > Christophe reported a major speedup due to avoiding the iov_iter > > overhead, so just add th

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Christophe Leroy
Le 06/09/2020 à 20:38, Pavel Machek a écrit : On Sun 2020-09-06 20:35:38, Christophe Leroy wrote: Hi, Le 06/09/2020 à 20:21, Pavel Machek a écrit : Hi! Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero alread

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Pavel Machek
On Sun 2020-09-06 20:35:38, Christophe Leroy wrote: > Hi, > > Le 06/09/2020 à 20:21, Pavel Machek a écrit : > >Hi! > > > Christophe reported a major speedup due to avoiding the iov_iter > overhead, so just add this trivial function. Note that /dev/zero > already implements both an ite

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Christophe Leroy
Hi, Le 06/09/2020 à 20:21, Pavel Machek a écrit : Hi! Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero already implements both an iter and non-iter writes so this just makes it more symmetric. Christophe Leroy

Re: [PATCH] /dev/zero: also implement ->read

2020-09-06 Thread Pavel Machek
Hi! > > > Christophe reported a major speedup due to avoiding the iov_iter > > > overhead, so just add this trivial function. Note that /dev/zero > > > already implements both an iter and non-iter writes so this just > > > makes it more symmetric. > > > > > > Christophe Leroy > > > Signed-off-by

RE: [PATCH] /dev/zero: also implement ->read

2020-09-03 Thread David Laight
From: Christophe Leroy > > > Le 03/09/2020 à 17:59, Christoph Hellwig a écrit : > > Christophe reported a major speedup due to avoiding the iov_iter > > overhead, so just add this trivial function. Note that /dev/zero > > already implements both an iter and non-iter writes so this just > > makes

Re: [PATCH] /dev/zero: also implement ->read

2020-09-03 Thread Greg KH
On Thu, Sep 03, 2020 at 07:51:07PM +0200, Christophe Leroy wrote: > > > Le 03/09/2020 à 17:59, Christoph Hellwig a écrit : > > Christophe reported a major speedup due to avoiding the iov_iter > > overhead, so just add this trivial function. Note that /dev/zero > > already implements both an iter

Re: [PATCH] /dev/zero: also implement ->read

2020-09-03 Thread Christophe Leroy
Le 03/09/2020 à 17:59, Christoph Hellwig a écrit : Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero already implements both an iter and non-iter writes so this just makes it more symmetric. Christophe Leroy Sig

Re: [PATCH] /dev/zero: also implement ->read

2020-09-03 Thread Christophe Leroy
Le 03/09/2020 à 17:59, Christoph Hellwig a écrit : Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero already implements both an iter and non-iter writes so this just makes it more symmetric. Christophe Leroy Sig

[PATCH] /dev/zero: also implement ->read

2020-09-03 Thread Christoph Hellwig
Christophe reported a major speedup due to avoiding the iov_iter overhead, so just add this trivial function. Note that /dev/zero already implements both an iter and non-iter writes so this just makes it more symmetric. Christophe Leroy Signed-off-by: Christoph Hellwig --- drivers/char/mem.c |