Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Roland Dreier
Al> PS: note that it's not depends on PCI it's depends on PCI || Al> BROKEN which a) documents that something is wrong b) leaves Al> all setups usable now intact c) prevents broken setups from Al> being picked. Yes, I agree that this makes sense for now. Al> I certainly agree

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Al Viro
On Wed, Aug 24, 2005 at 05:31:34PM +0100, Al Viro wrote: > On Wed, Aug 24, 2005 at 09:22:27AM -0700, Roland Dreier wrote: > > Al> infiniband uses PCI helpers all over the place (including the > > Al> core parts) and won't build without PCI. > > > > I don't think this is the right fix. The

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Al Viro
On Wed, Aug 24, 2005 at 09:22:27AM -0700, Roland Dreier wrote: > Al> infiniband uses PCI helpers all over the place (including the > Al> core parts) and won't build without PCI. > > I don't think this is the right fix. The only PCI helpers used in > code that is enabled with CONFIG_PCI=n

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Roland Dreier
Al> infiniband uses PCI helpers all over the place (including the Al> core parts) and won't build without PCI. I don't think this is the right fix. The only PCI helpers used in code that is enabled with CONFIG_PCI=n are pci_unmap_addr_set() and pci_unmap_addr(). And they're only used bec

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Al Viro
On Wed, Aug 24, 2005 at 05:26:09PM +0200, Adrian Bunk wrote: > As I said, on i386. Builds due to stubs being still present, doesn't do anything since it doesn't even try to look for any hardware in that case. > > have PCI at all - same situation as with firewire. Note that you won't > > get any

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Adrian Bunk
On Wed, Aug 24, 2005 at 03:57:36PM +0100, Al Viro wrote: > On Wed, Aug 24, 2005 at 01:26:55PM +0200, Adrian Bunk wrote: > > On Tue, Aug 23, 2005 at 10:45:41PM +0100, Al Viro wrote: > > > > > infiniband uses PCI helpers all over the place (including the core parts) > > > and > > > won't build with

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Al Viro
On Wed, Aug 24, 2005 at 01:26:55PM +0200, Adrian Bunk wrote: > On Tue, Aug 23, 2005 at 10:45:41PM +0100, Al Viro wrote: > > > infiniband uses PCI helpers all over the place (including the core parts) > > and > > won't build without PCI. > >... > > CONFIG_INFINIBAND=y and CONFIG_PCI=n compiles fo

Re: [PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-24 Thread Adrian Bunk
On Tue, Aug 23, 2005 at 10:45:41PM +0100, Al Viro wrote: > infiniband uses PCI helpers all over the place (including the core parts) and > won't build without PCI. >... CONFIG_INFINIBAND=y and CONFIG_PCI=n compiles for me on i386. Can you post the compile error you got? cu Adrian -- "

[PATCH] (11/43) Kconfig fix (infiniband and PCI)

2005-08-23 Thread Al Viro
infiniband uses PCI helpers all over the place (including the core parts) and won't build without PCI. Signed-off-by: Al Viro <[EMAIL PROTECTED]> diff -urN RC13-rc6-git13-m32r-pagealloc/drivers/infiniband/Kconfig RC13-rc6-git13-infiniband/drivers/infiniband/Kconfig --- RC13-rc6-git13-m32r-pa