Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-29 Thread Valentine Barshak
Josh Boyer wrote: On Wed, 23 Jan 2008 23:37:33 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: logical/bitand typo Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-29 Thread Roel Kluin
>>> On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: - if (val && 0x1) + if (val & 0x1) >> Joe Perches wrote: >>> I think this pattern should be added to checkpatch >>> + if ($line =~ /\&\&\s*0[xX]/) { > On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Klui

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-29 Thread Andy Whitcroft
On Thu, Jan 24, 2008 at 01:18:48AM +0100, Roel Kluin wrote: > Joe Perches wrote: > > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: > >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > >> --- > >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > >> index ebf9e21..dcfb459 10064

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-26 Thread Stefan Roese
On Thursday 24 January 2008, Josh Boyer wrote: > On Wed, 23 Jan 2008 23:37:33 +0100 > > Roel Kluin <[EMAIL PROTECTED]> wrote: > > logical/bitand typo > > > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > > --- > > diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > > index ebf9e21..d

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Josh Boyer
On Wed, 23 Jan 2008 23:37:33 +0100 Roel Kluin <[EMAIL PROTECTED]> wrote: > logical/bitand typo > > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > index ebf9e21..dcfb459 100644 > --- a/arch/powerpc/boot/4xx.c > +++ b/arch/powe

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Joe Perches
On Thu, 2008-01-24 at 01:18 +0100, Roel Kluin wrote: > when you use git-grep -n "\(&&\|||\)${s}0x\([A-Z0-9]*\|[a-z0-9]*\)", > (with s="[[:space:]]*") there will be false positives [] > so i'd propose to change that to > +# Check for bitwise tests written as boolean > + if ($line =~ /(?:

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Roel Kluin
Joe Perches wrote: > On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: >> Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> >> --- >> diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c >> index ebf9e21..dcfb459 100644 >> --- a/arch/powerpc/boot/4xx.c >> +++ b/arch/powerpc/boot/4xx.c >> @

Re: [PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Joe Perches
On Wed, 2008-01-23 at 23:37 +0100, Roel Kluin wrote: > Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> > --- > diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c > index ebf9e21..dcfb459 100644 > --- a/arch/powerpc/boot/4xx.c > +++ b/arch/powerpc/boot/4xx.c > @@ -104,7 +104,7 @@ void ibm4

[PATCH][ppc] logical/bitand typo in powerpc/boot/4xx.c

2008-01-23 Thread Roel Kluin
logical/bitand typo Signed-off-by: Roel Kluin <[EMAIL PROTECTED]> --- diff --git a/arch/powerpc/boot/4xx.c b/arch/powerpc/boot/4xx.c index ebf9e21..dcfb459 100644 --- a/arch/powerpc/boot/4xx.c +++ b/arch/powerpc/boot/4xx.c @@ -104,7 +104,7 @@ void ibm4xx_denali_fixup_memsize(void) val = DD