Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue

2020-11-23 Thread Martin K. Petersen
On Wed, 18 Nov 2020 13:13:45 +, Colin King wrote: > There is a null check on pointer lpfc_cmd after the pointer has been > dereferenced when pointers rdata and ndlp are initialized at the start > of the function. Fix this by only assigning rdata and ndlp after the > pointer lpfc_cmd has been n

Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue

2020-11-19 Thread Martin K. Petersen
Colin, > There is a null check on pointer lpfc_cmd after the pointer has been > dereferenced when pointers rdata and ndlp are initialized at the start > of the function. Fix this by only assigning rdata and ndlp after the > pointer lpfc_cmd has been null checked. Applied to 5.11/scsi-staging, t

Re: [PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue

2020-11-19 Thread James Smart
On 11/18/2020 5:13 AM, Colin King wrote: From: Colin Ian King There is a null check on pointer lpfc_cmd after the pointer has been dereferenced when pointers rdata and ndlp are initialized at the start of the function. Fix this by only assigning rdata and ndlp after the pointer lpfc_cmd has b

[PATCH][next] scsi: lpfc: fix pointer defereference before it is null checked issue

2020-11-18 Thread Colin King
From: Colin Ian King There is a null check on pointer lpfc_cmd after the pointer has been dereferenced when pointers rdata and ndlp are initialized at the start of the function. Fix this by only assigning rdata and ndlp after the pointer lpfc_cmd has been null checked. Addresses-Coverity: ("Dere