[PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

2021-03-03 Thread Colin King
From: Colin Ian King The less than zero comparison with status is always false because status is a u8. Fix this by using ret as the return check for the call to chip->legacy.waitfunc() and checking on this and assigning status to ret if it is OK. Addresses-Coverity: ("Unsigned compared against 0

Re: [PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

2021-03-03 Thread Colin Ian King
On 03/03/2021 09:46, Miquel Raynal wrote: > Hi Colin, > > Colin King wrote on Wed, 3 Mar 2021 > 09:42:46 +: > >> From: Colin Ian King >> >> The less than zero comparison with status is always false because status >> is a u8. Fix this by using ret as the return check for the call to >> chip

Re: [PATCH][next] mtd: nand: Fix error handling in nand_prog_page_op

2021-03-03 Thread Miquel Raynal
Hi Colin, Colin King wrote on Wed, 3 Mar 2021 09:42:46 +: > From: Colin Ian King > > The less than zero comparison with status is always false because status > is a u8. Fix this by using ret as the return check for the call to > chip->legacy.waitfunc() and checking on this and assigning s