Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-22 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2019 at 09:26:05AM -0700, Kees Cook wrote: > On Fri, Jun 21, 2019 at 04:05:09PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 21, 2019 at 04:03:47PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > > > From: Colin Ian King >

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Kees Cook
On Fri, Jun 21, 2019 at 04:05:09PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 21, 2019 at 04:03:47PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > > From: Colin Ian King > > > > > > The variable ret is being initialized with the value -EI

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Fri, Jun 21, 2019 at 04:03:47PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > From: Colin Ian King > > > > The variable ret is being initialized with the value -EINVAL however > > this value is never read and ret is being re-assigned later o

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with the value -EINVAL however > this value is never read and ret is being re-assigned later on. Hence > the initialization is redundant and can be removed. > > Addresses-

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-21 Thread Greg Kroah-Hartman
On Thu, Jun 20, 2019 at 11:13:32AM -0700, Kees Cook wrote: > On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > > From: Colin Ian King > > > > The variable ret is being initialized with the value -EINVAL however > > this value is never read and ret is being re-assigned later on. Hence

Re: [PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-20 Thread Kees Cook
On Fri, Jun 14, 2019 at 10:43:11AM +0100, Colin King wrote: > From: Colin Ian King > > The variable ret is being initialized with the value -EINVAL however > this value is never read and ret is being re-assigned later on. Hence > the initialization is redundant and can be removed. > > Addresses-

[PATCH][next] lkdtm: remove redundant initialization of ret

2019-06-14 Thread Colin King
From: Colin Ian King The variable ret is being initialized with the value -EINVAL however this value is never read and ret is being re-assigned later on. Hence the initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/mis